| Message ID | 20200815103734.31153-12-dafna.hirschfeld@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: staging: rkisp1: various bug fixes | expand |
On 8/15/20 7:37 AM, Dafna Hirschfeld wrote: > The signal RKISP1_CIF_ISP_FRAME_IN is not used in the isr so > there is no need to enable it. I saw in the docs this is for when sampled input frame is complete. (I was just wondering for curiosity what is a sampled input frame here, but never mind). > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> Thanks, Helen > --- > drivers/staging/media/rkisp1/rkisp1-isp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-isp.c b/drivers/staging/media/rkisp1/rkisp1-isp.c > index 33cfad19dde2..912eb6ad4e0a 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-isp.c > +++ b/drivers/staging/media/rkisp1/rkisp1-isp.c > @@ -348,7 +348,7 @@ static int rkisp1_config_isp(struct rkisp1_device *rkisp1) > rkisp1_write(rkisp1, sink_crop->height, RKISP1_CIF_ISP_OUT_V_SIZE); > > irq_mask |= RKISP1_CIF_ISP_FRAME | RKISP1_CIF_ISP_V_START | > - RKISP1_CIF_ISP_PIC_SIZE_ERROR | RKISP1_CIF_ISP_FRAME_IN; > + RKISP1_CIF_ISP_PIC_SIZE_ERROR; > rkisp1_write(rkisp1, irq_mask, RKISP1_CIF_ISP_IMSC); > > if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) { >
Am 17.08.20 um 23:48 schrieb Helen Koike: > > > On 8/15/20 7:37 AM, Dafna Hirschfeld wrote: >> The signal RKISP1_CIF_ISP_FRAME_IN is not used in the isr so >> there is no need to enable it. > > I saw in the docs this is for when sampled input frame is complete. > (I was just wondering for curiosity what is a sampled input frame > here, but never mind). Hi, I discussed the meaning of the interrupts with Tomasz, https://patchwork.kernel.org/patch/11066513/#23505185 Thanks, Dafna > >> >> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > > Acked-by: Helen Koike <helen.koike@collabora.com> > > Thanks, > Helen > >> --- >> drivers/staging/media/rkisp1/rkisp1-isp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/rkisp1/rkisp1-isp.c b/drivers/staging/media/rkisp1/rkisp1-isp.c >> index 33cfad19dde2..912eb6ad4e0a 100644 >> --- a/drivers/staging/media/rkisp1/rkisp1-isp.c >> +++ b/drivers/staging/media/rkisp1/rkisp1-isp.c >> @@ -348,7 +348,7 @@ static int rkisp1_config_isp(struct rkisp1_device *rkisp1) >> rkisp1_write(rkisp1, sink_crop->height, RKISP1_CIF_ISP_OUT_V_SIZE); >> >> irq_mask |= RKISP1_CIF_ISP_FRAME | RKISP1_CIF_ISP_V_START | >> - RKISP1_CIF_ISP_PIC_SIZE_ERROR | RKISP1_CIF_ISP_FRAME_IN; >> + RKISP1_CIF_ISP_PIC_SIZE_ERROR; >> rkisp1_write(rkisp1, irq_mask, RKISP1_CIF_ISP_IMSC); >> >> if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) { >> >
diff --git a/drivers/staging/media/rkisp1/rkisp1-isp.c b/drivers/staging/media/rkisp1/rkisp1-isp.c index 33cfad19dde2..912eb6ad4e0a 100644 --- a/drivers/staging/media/rkisp1/rkisp1-isp.c +++ b/drivers/staging/media/rkisp1/rkisp1-isp.c @@ -348,7 +348,7 @@ static int rkisp1_config_isp(struct rkisp1_device *rkisp1) rkisp1_write(rkisp1, sink_crop->height, RKISP1_CIF_ISP_OUT_V_SIZE); irq_mask |= RKISP1_CIF_ISP_FRAME | RKISP1_CIF_ISP_V_START | - RKISP1_CIF_ISP_PIC_SIZE_ERROR | RKISP1_CIF_ISP_FRAME_IN; + RKISP1_CIF_ISP_PIC_SIZE_ERROR; rkisp1_write(rkisp1, irq_mask, RKISP1_CIF_ISP_IMSC); if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
The signal RKISP1_CIF_ISP_FRAME_IN is not used in the isr so there is no need to enable it. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- drivers/staging/media/rkisp1/rkisp1-isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)