| Message ID | 20200818130424.20522-4-mhartmay@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: Add Protected VM support | expand |
On Tue, Aug 18, 2020 at 03:04:23PM +0200, Marc Hartmayer wrote: > This allows us, for example, to auto generate a new test case based on > an existing test case. > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> > --- > scripts/common.bash | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/scripts/common.bash b/scripts/common.bash > index c7acdf14a835..a6044b7c6c35 100644 > --- a/scripts/common.bash > +++ b/scripts/common.bash > @@ -19,7 +19,7 @@ function for_each_unittest() > while read -r -u $fd line; do > if [[ "$line" =~ ^\[(.*)\]$ ]]; then > if [ -n "${testname}" ]; then > - "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > + $(arch_cmd) "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > fi > testname=${BASH_REMATCH[1]} > smp=1 > @@ -49,11 +49,16 @@ function for_each_unittest() > fi > done > if [ -n "${testname}" ]; then > - "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > + $(arch_cmd) "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > fi > exec {fd}<&- > } > > +function arch_cmd() > +{ > + [ "${ARCH_CMD}" ] && echo "${ARCH_CMD}" > +} > + > # The current file has to be the only file sourcing the arch helper > # file > ARCH_FUNC=scripts/${ARCH}/func.bash > -- > 2.25.4 > Reviewed-by: Andrew Jones <drjones@redhat.com>
On Tue, 18 Aug 2020 15:04:23 +0200 Marc Hartmayer <mhartmay@linux.ibm.com> wrote: > This allows us, for example, to auto generate a new test case based on > an existing test case. > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> > --- > scripts/common.bash | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck <cohuck@redhat.com>
On 18.08.20 15:04, Marc Hartmayer wrote: > This allows us, for example, to auto generate a new test case based on > an existing test case. An example would have been nice :) > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> > --- > scripts/common.bash | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/scripts/common.bash b/scripts/common.bash > index c7acdf14a835..a6044b7c6c35 100644 > --- a/scripts/common.bash > +++ b/scripts/common.bash > @@ -19,7 +19,7 @@ function for_each_unittest() > while read -r -u $fd line; do > if [[ "$line" =~ ^\[(.*)\]$ ]]; then > if [ -n "${testname}" ]; then > - "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > + $(arch_cmd) "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > fi > testname=${BASH_REMATCH[1]} > smp=1 > @@ -49,11 +49,16 @@ function for_each_unittest() > fi > done > if [ -n "${testname}" ]; then > - "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > + $(arch_cmd) "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" > fi > exec {fd}<&- > } > > +function arch_cmd() > +{ > + [ "${ARCH_CMD}" ] && echo "${ARCH_CMD}" > +} > + > # The current file has to be the only file sourcing the arch helper > # file > ARCH_FUNC=scripts/${ARCH}/func.bash > Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/scripts/common.bash b/scripts/common.bash index c7acdf14a835..a6044b7c6c35 100644 --- a/scripts/common.bash +++ b/scripts/common.bash @@ -19,7 +19,7 @@ function for_each_unittest() while read -r -u $fd line; do if [[ "$line" =~ ^\[(.*)\]$ ]]; then if [ -n "${testname}" ]; then - "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" + $(arch_cmd) "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" fi testname=${BASH_REMATCH[1]} smp=1 @@ -49,11 +49,16 @@ function for_each_unittest() fi done if [ -n "${testname}" ]; then - "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" + $(arch_cmd) "$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" fi exec {fd}<&- } +function arch_cmd() +{ + [ "${ARCH_CMD}" ] && echo "${ARCH_CMD}" +} + # The current file has to be the only file sourcing the arch helper # file ARCH_FUNC=scripts/${ARCH}/func.bash
This allows us, for example, to auto generate a new test case based on an existing test case. Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> --- scripts/common.bash | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)