diff mbox series

[V2] ARM: dts: imx6q-logicpd: Fix broken PWM

Message ID 20200819194845.2866317-1-aford173@gmail.com (mailing list archive)
State New, archived
Headers show
Series [V2] ARM: dts: imx6q-logicpd: Fix broken PWM | expand

Commit Message

Adam Ford Aug. 19, 2020, 7:48 p.m. UTC 
The DTC doesn't like the default PWM settings, because it's expecting
three cells.  This patch reduces adds the extra entry of 0 to the PWM
reference.

Fixes:  fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
---
V2:  Don't change HDMI

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Fabio Estevam Aug. 19, 2020, 7:54 p.m. UTC | #1 
Hi Adam,

On Wed, Aug 19, 2020 at 4:48 PM Adam Ford <aford173@gmail.com> wrote:
>
> The DTC doesn't like the default PWM settings, because it's expecting
> three cells.  This patch reduces adds the extra entry of 0 to the PWM
> reference.
>
> Fixes:  fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
> ---
> V2:  Don't change HDMI
>
> Signed-off-by: Adam Ford <aford173@gmail.com>

Your Signed-off-by tag should go below the Fixes line (without a blank
line between) and above the --- line.

With that fixed you can add:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
index 7a3d1d3e54a9..8f94364ba484 100644
--- a/arch/arm/boot/dts/imx6q-logicpd.dts
+++ b/arch/arm/boot/dts/imx6q-logicpd.dts
@@ -13,7 +13,7 @@  / {
 
 	backlight: backlight-lvds {
 		compatible = "pwm-backlight";
-		pwms = <&pwm3 0 20000>;
+		pwms = <&pwm3 0 20000 0>;
 		brightness-levels = <0 4 8 16 32 64 128 255>;
 		default-brightness-level = <6>;
 		power-supply = <&reg_lcd>;