diff mbox series

ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy

Message ID 20200817030401.3124855-1-cphealy@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy | expand

Commit Message

Chris Healy Aug. 17, 2020, 3:04 a.m. UTC 
From: Chris Healy <cphealy@gmail.com>

Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.

Fix it by switching to phy-mode = "rgmii-id".

Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
 arch/arm/boot/dts/imx7d-zii-rmu2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Aug. 22, 2020, 7:59 p.m. UTC | #1 
Hi Chris,

On Mon, Aug 17, 2020 at 12:04 AM Chris Healy <cphealy@gmail.com> wrote:
>
> From: Chris Healy <cphealy@gmail.com>
>
> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.
>
> Fix it by switching to phy-mode = "rgmii-id".

The patch looks good, but the commit log could be improved to explain
more about the reason for the breakage.

Please check commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X
phy-mode") as a reference.
Chris Healy Aug. 22, 2020, 8:06 p.m. UTC | #2 
On Sat, Aug 22, 2020 at 12:59 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> On Mon, Aug 17, 2020 at 12:04 AM Chris Healy <cphealy@gmail.com> wrote:
> >
> > From: Chris Healy <cphealy@gmail.com>
> >
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> > KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.
> >
> > Fix it by switching to phy-mode = "rgmii-id".
>
> The patch looks good, but the commit log could be improved to explain
> more about the reason for the breakage.
>
> Please check commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X
> phy-mode") as a reference.

Sounds good, I'll improve the commit log in v2.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx7d-zii-rmu2.dts b/arch/arm/boot/dts/imx7d-zii-rmu2.dts
index e5e20b07f184..7cb6153fc650 100644
--- a/arch/arm/boot/dts/imx7d-zii-rmu2.dts
+++ b/arch/arm/boot/dts/imx7d-zii-rmu2.dts
@@ -58,7 +58,7 @@  &fec1 {
 			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
 	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
 	assigned-clock-rates = <0>, <100000000>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&fec1_phy>;
 	status = "okay";