| Message ID | 20200729104933.1.If8e80e4c0c7ddf99056f6e726e59505ed4e127f3@changeid (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | interconnect: Show bandwidth for disabled paths as zero in debugfs | expand |
On Wed, Jul 29, 2020 at 10:50:12AM -0700, Matthias Kaehlcke wrote: > For disabled paths the 'interconnect_summary' in debugfs currently shows > the orginally requested bandwidths. This is confusing, since the bandwidth > requests aren't active. Instead show the bandwidths for disabled > paths/requests as zero. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> ping, any comments on this?
On Wed, Jul 29, 2020 at 10:50 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > For disabled paths the 'interconnect_summary' in debugfs currently shows > the orginally requested bandwidths. This is confusing, since the bandwidth > requests aren't active. Instead show the bandwidths for disabled > paths/requests as zero. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Looks good to me. I briefly mulled over the idea of showing the disabled flag as a separate column, but I can't really think of how that would be useful. Reviewed-by: Evan Green <evgreen@chromium.org>
Hi Matthias, Thanks for the patch! On 8/25/20 03:08, Matthias Kaehlcke wrote: > On Wed, Jul 29, 2020 at 10:50:12AM -0700, Matthias Kaehlcke wrote: >> For disabled paths the 'interconnect_summary' in debugfs currently shows >> the orginally requested bandwidths. This is confusing, since the bandwidth >> requests aren't active. Instead show the bandwidths for disabled >> paths/requests as zero. >> >> Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > ping, any comments on this? > Looks good to me! Just in case, I'll also add: Fixes: 7d374b209083 ("interconnect: Add helpers for enabling/disabling a path") Thanks, Georgi
diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index 609e206bf598..3491175304d1 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -55,12 +55,18 @@ static int icc_summary_show(struct seq_file *s, void *data) icc_summary_show_one(s, n); hlist_for_each_entry(r, &n->req_list, req_node) { + u32 avg_bw = 0, peak_bw = 0; + if (!r->dev) continue; + if (r->enabled) { + avg_bw = r->avg_bw; + peak_bw = r->peak_bw; + } + seq_printf(s, " %-27s %12u %12u %12u\n", - dev_name(r->dev), r->tag, r->avg_bw, - r->peak_bw); + dev_name(r->dev), r->tag, avg_bw, peak_bw); } } }
For disabled paths the 'interconnect_summary' in debugfs currently shows the orginally requested bandwidths. This is confusing, since the bandwidth requests aren't active. Instead show the bandwidths for disabled paths/requests as zero. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- drivers/interconnect/core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)