[v2,0/2] skipping manual flush for write booster

Message

Kiwoong Kim Aug. 24, 2020, 2:29 a.m. UTC

v2 -> v1: enable the quirk in exynos

We have two knobs to flush for write booster, i.e.
fWriteBoosterEn, fWriteBoosterBufferFlushEn.
However, many product makers uses only fWriteBoosterBufferFlushEn,
because this can reportedly cover most scenarios and
there have been some reports that flush by fWriteBoosterEn could
lead raise power consumption thanks to unexpected internal
operations. So we need a way to enable or disable fWriteBoosterEn.

Kiwoong Kim (2):
  ufs: introduce skipping manual flush for wb
  ufs: exynos: enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

 drivers/scsi/ufs/ufs-exynos.c | 3 ++-
 drivers/scsi/ufs/ufshcd.c     | 3 +++
 drivers/scsi/ufs/ufshcd.h     | 5 +++++
 3 files changed, 10 insertions(+), 1 deletion(-)

Comments

Avri Altman Aug. 24, 2020, 6:46 a.m. UTC | #1

> 
> v2 -> v1: enable the quirk in exynos
> 
> We have two knobs to flush for write booster, i.e.
> fWriteBoosterEn, fWriteBoosterBufferFlushEn.
fWriteBoosterBufferFlushDuringHibernate and fWriteBoosterBufferFlushEn.

> However, many product makers uses only fWriteBoosterBufferFlushEn,
Uses only fWriteBoosterBufferFlushDuringHibernate
> because this can reportedly cover most scenarios and
> there have been some reports that flush by fWriteBoosterEn could
flush by fWriteBoosterBufferFlushEn could

> lead raise power consumption thanks to unexpected internal
lead to a raise

> operations. So we need a way to enable or disable fWriteBoosterEn.
operations. For those case, this quirk will allow to avoid manual flush.

Kiwoong Kim Aug. 25, 2020, 1:59 a.m. UTC | #2

> > v2 -> v1: enable the quirk in exynos
> >
> > We have two knobs to flush for write booster, i.e.
> > fWriteBoosterEn, fWriteBoosterBufferFlushEn.
> fWriteBoosterBufferFlushDuringHibernate and fWriteBoosterBufferFlushEn.
> 
> > However, many product makers uses only fWriteBoosterBufferFlushEn,
> Uses only fWriteBoosterBufferFlushDuringHibernate
> > because this can reportedly cover most scenarios and there have been
> > some reports that flush by fWriteBoosterEn could
> flush by fWriteBoosterBufferFlushEn could
> 
> > lead raise power consumption thanks to unexpected internal
> lead to a raise
> 
> > operations. So we need a way to enable or disable fWriteBoosterEn.
> operations. For those case, this quirk will allow to avoid manual flush. 

It was my mistake and I'll be more careful when writing messages.

Thanks.
Kiwoong Kim