| Message ID | 20200825112447.126308-3-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | trivial patchs for static code analyzer fixes | expand |
On Tue, 25 Aug 2020 at 12:26, Chen Qun <kuhn.chenqun@huawei.com> wrote: > > Clang static code analyzer show warning: > hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its > initialization is never read > CPUState *cpu = CPU(s->cpu); > ^~~ ~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Chen Qun <kuhn.chenqun@huawei.com> 于2020年8月25日周二 下午7:30写道： > > Clang static code analyzer show warning: > hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its > initialization is never read > CPUState *cpu = CPU(s->cpu); > ^~~ ~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: qemu-arm@nongnu.org > --- > hw/arm/omap1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c > index 6ba0df6b6d..02c0f66431 100644 > --- a/hw/arm/omap1.c > +++ b/hw/arm/omap1.c > @@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr addr, > return s->clkm.dsp_rstct2; > > case 0x18: /* DSP_SYSST */ > - cpu = CPU(s->cpu); > return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start | > (cpu->halted << 6); /* Quite useless... */ > } > -- > 2.23.0 > >
diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index 6ba0df6b6d..02c0f66431 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/omap1.c @@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr addr, return s->clkm.dsp_rstct2; case 0x18: /* DSP_SYSST */ - cpu = CPU(s->cpu); return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start | (cpu->halted << 6); /* Quite useless... */ }
Clang static code analyzer show warning: hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its initialization is never read CPUState *cpu = CPU(s->cpu); ^~~ ~~~~~~~~~~~ Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- Cc: Peter Maydell <peter.maydell@linaro.org> Cc: qemu-arm@nongnu.org --- hw/arm/omap1.c | 1 - 1 file changed, 1 deletion(-)