| Message ID | 20200825112447.126308-8-kuhn.chenqun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | trivial patchs for static code analyzer fixes | expand |
On Tue, Aug 25, 2020 at 07:24:44PM +0800, Chen Qun wrote: > Clang static code analyzer show warning: > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read > ret = event_notifier_test_and_clear(intp->interrupt); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Eric Auger <eric.auger@redhat.com> > --- > Cc: Alex Williamson <alex.williamson@redhat.com> > Cc: Eric Auger <eric.auger@redhat.com> > Cc: Stefan Hajnoczi <stefanha@redhat.com> > --- > hw/vfio/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Chen Qun <kuhn.chenqun@huawei.com> 于2020年8月25日周二 下午7:31写道： > > Clang static code analyzer show warning: > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read > ret = event_notifier_test_and_clear(intp->interrupt); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Eric Auger <eric.auger@redhat.com> > --- > Cc: Alex Williamson <alex.williamson@redhat.com> > Cc: Eric Auger <eric.auger@redhat.com> > Cc: Stefan Hajnoczi <stefanha@redhat.com> > --- > hw/vfio/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c > index ac2cefc9b1..869ed2c39d 100644 > --- a/hw/vfio/platform.c > +++ b/hw/vfio/platform.c > @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) > trace_vfio_intp_interrupt_set_pending(intp->pin); > QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, > intp, pqnext); > - ret = event_notifier_test_and_clear(intp->interrupt); Shouldn't we check the 'ret' like the other place in this function? Thanks, Li Qiang > + event_notifier_test_and_clear(intp->interrupt); > return; > } > > -- > 2.23.0 > >
> > Clang static code analyzer show warning: > > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read > > ret = event_notifier_test_and_clear(intp->interrupt); > > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Reported-by: Euler Robot <euler.robot@huawei.com> > > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > > Reviewed-by: Eric Auger <eric.auger@redhat.com> > > --- > > Cc: Alex Williamson <alex.williamson@redhat.com> > > Cc: Eric Auger <eric.auger@redhat.com> > > Cc: Stefan Hajnoczi <stefanha@redhat.com> > > --- > > hw/vfio/platform.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index > > ac2cefc9b1..869ed2c39d 100644 > > --- a/hw/vfio/platform.c > > +++ b/hw/vfio/platform.c > > @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) > > trace_vfio_intp_interrupt_set_pending(intp->pin); > > QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, > > intp, pqnext); > > - ret = event_notifier_test_and_clear(intp->interrupt); > > Shouldn't we check the 'ret' like the other place in this function? Hi, Li Qiang, Eric、Alex、Stefan has already discussed this point in the V1 version. https://patchwork.kernel.org/patch/11711897/ Thanks.
Chenqun (kuhn) <kuhn.chenqun@huawei.com> 于2020年8月26日周三 上午9:47写道： > > > > > Clang static code analyzer show warning: > > > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read > > > ret = event_notifier_test_and_clear(intp->interrupt); > > > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > Reported-by: Euler Robot <euler.robot@huawei.com> > > > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > > > Reviewed-by: Eric Auger <eric.auger@redhat.com> > > > --- > > > Cc: Alex Williamson <alex.williamson@redhat.com> > > > Cc: Eric Auger <eric.auger@redhat.com> > > > Cc: Stefan Hajnoczi <stefanha@redhat.com> > > > --- > > > hw/vfio/platform.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index > > > ac2cefc9b1..869ed2c39d 100644 > > > --- a/hw/vfio/platform.c > > > +++ b/hw/vfio/platform.c > > > @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) > > > trace_vfio_intp_interrupt_set_pending(intp->pin); > > > QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, > > > intp, pqnext); > > > - ret = event_notifier_test_and_clear(intp->interrupt); > > > > Shouldn't we check the 'ret' like the other place in this function? > > Hi, Li Qiang, > > Eric、Alex、Stefan has already discussed this point in the V1 version. > https://patchwork.kernel.org/patch/11711897/ Ok I see, then Reviewed-by: Li Qiang <liq3ea@gmail.com> Thanks, Li Qiang > > Thanks.
diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index ac2cefc9b1..869ed2c39d 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp) trace_vfio_intp_interrupt_set_pending(intp->pin); QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue, intp, pqnext); - ret = event_notifier_test_and_clear(intp->interrupt); + event_notifier_test_and_clear(intp->interrupt); return; }
Clang static code analyzer show warning: hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read ret = event_notifier_test_and_clear(intp->interrupt); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> Reviewed-by: Eric Auger <eric.auger@redhat.com> --- Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Eric Auger <eric.auger@redhat.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> --- hw/vfio/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)