| Message ID | 20200826111826.3168-1-akshu.agrawal@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: AMD: Clean kernel log from deferred probe error messages | expand |
On Wed, Aug 26, 2020 at 04:48:05PM +0530, Akshu Agrawal wrote: > While the driver waits for DAIs to be probed and retries probing, > avoid printing error messages. This means that if there is a problem with deferred probe no diagnostics will be available, there should be something at least at debug level.
On 8/26/2020 4:54 PM, Mark Brown wrote: > On Wed, Aug 26, 2020 at 04:48:05PM +0530, Akshu Agrawal wrote: >> While the driver waits for DAIs to be probed and retries probing, >> avoid printing error messages. > This means that if there is a problem with deferred probe no diagnostics > will be available, there should be something at least at debug level. Sure will add a message at debug level for deferred probe. Thanks, Akshu
diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c index 406526e79af3..67f80ba51de0 100644 --- a/sound/soc/amd/acp3x-rt5682-max9836.c +++ b/sound/soc/amd/acp3x-rt5682-max9836.c @@ -471,13 +471,11 @@ static int acp3x_probe(struct platform_device *pdev) } ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) { + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "devm_snd_soc_register_card(%s) failed: %d\n", card->name, ret); - return ret; - } - return 0; + return ret; } static const struct acpi_device_id acp3x_audio_acpi_match[] = {
While the driver waits for DAIs to be probed and retries probing, avoid printing error messages. Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> --- sound/soc/amd/acp3x-rt5682-max9836.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)