| Message ID | 20200827060441.15487-3-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Fixes and improvements for brcmfmac driver | expand |
27.08.2020 09:23, Gustavo A. R. Silva пишет: > Hi, > > There is a patch that address this, already: > > https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/ > > Thanks Okay, then my patch is unnecessary. Thank you!
Hi, There is a patch that address this, already: https://lore.kernel.org/lkml/20200821063758.GA17783@embeddedor/ Thanks -- Gustavo On 8/27/20 01:04, Dmitry Osipenko wrote: > There is no need to insert the "fallthrough" comment if there is nothing > in-between of case switches. Hence let's remove the unnecessary comments > in order to make code cleaner a tad. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 -- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c > index 1a7ab49295aa..0dc4de2fa9f6 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c > @@ -916,9 +916,7 @@ int brcmf_sdiod_probe(struct brcmf_sdio_dev *sdiodev) > f2_blksz = SDIO_4373_FUNC2_BLOCKSIZE; > break; > case SDIO_DEVICE_ID_BROADCOM_4359: > - /* fallthrough */ > case SDIO_DEVICE_ID_BROADCOM_4354: > - /* fallthrough */ > case SDIO_DEVICE_ID_BROADCOM_4356: > f2_blksz = SDIO_435X_FUNC2_BLOCKSIZE; > break; > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > index ac3ee93a2378..b16944a898f9 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > @@ -4306,9 +4306,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err, > CY_43455_MESBUSYCTRL, &err); > break; > case SDIO_DEVICE_ID_BROADCOM_4359: > - /* fallthrough */ > case SDIO_DEVICE_ID_BROADCOM_4354: > - /* fallthrough */ > case SDIO_DEVICE_ID_BROADCOM_4356: > brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n", > CY_435X_F2_WATERMARK); >
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c index 1a7ab49295aa..0dc4de2fa9f6 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c @@ -916,9 +916,7 @@ int brcmf_sdiod_probe(struct brcmf_sdio_dev *sdiodev) f2_blksz = SDIO_4373_FUNC2_BLOCKSIZE; break; case SDIO_DEVICE_ID_BROADCOM_4359: - /* fallthrough */ case SDIO_DEVICE_ID_BROADCOM_4354: - /* fallthrough */ case SDIO_DEVICE_ID_BROADCOM_4356: f2_blksz = SDIO_435X_FUNC2_BLOCKSIZE; break; diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index ac3ee93a2378..b16944a898f9 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -4306,9 +4306,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err, CY_43455_MESBUSYCTRL, &err); break; case SDIO_DEVICE_ID_BROADCOM_4359: - /* fallthrough */ case SDIO_DEVICE_ID_BROADCOM_4354: - /* fallthrough */ case SDIO_DEVICE_ID_BROADCOM_4356: brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n", CY_435X_F2_WATERMARK);
There is no need to insert the "fallthrough" comment if there is nothing in-between of case switches. Hence let's remove the unnecessary comments in order to make code cleaner a tad. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 -- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 -- 2 files changed, 4 deletions(-)