mbox series

[v2,0/2] scsi: target: tcmu: fix crashes on ARM

Message ID 20200618131632.32748-1-bstroesser@ts.fujitsu.com (mailing list archive)
Headers show
Series scsi: target: tcmu: fix crashes on ARM | expand

Message

Bodo Stroesser June 18, 2020, 1:16 p.m. UTC
This small series of patches consists of:
   [PATCH 1/2 v2] scsi: target: tcmu: Optimize use of flush_dcache_page
   [PATCH 2/2 v2] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range

Together with commit
   8c4e0f212398 scsi: target: tcmu: Fix size in calls to tcmu_flush_dcache_range
these patches fix crashes in tcmu on ARM.

The first patch of this series already was sent some weeks ago
as "PATCH RFC", since it was untested at that time.

Meanwhile I added patch 2 of the series to fix the crash reported in:
   https://github.com/open-iscsi/tcmu-runner/issues/627
   https://bugzilla.kernel.org/show_bug.cgi?id=208045

All three patches together were tested on ARM with kernel
4.19.118 and 5.7.2 (see github issue and bugzilla).

---
v2: sent with a valid subject line.

Comments

Mike Christie June 18, 2020, 4:04 p.m. UTC | #1
On 6/18/20 8:16 AM, Bodo Stroesser wrote:
> This small series of patches consists of:
>     [PATCH 1/2 v2] scsi: target: tcmu: Optimize use of flush_dcache_page
>     [PATCH 2/2 v2] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range
> 
> Together with commit
>     8c4e0f212398 scsi: target: tcmu: Fix size in calls to tcmu_flush_dcache_range
> these patches fix crashes in tcmu on ARM.
> 
> The first patch of this series already was sent some weeks ago
> as "PATCH RFC", since it was untested at that time.
> 
> Meanwhile I added patch 2 of the series to fix the crash reported in:
>     https://urldefense.com/v3/__https://github.com/open-iscsi/tcmu-runner/issues/627__;!!GqivPVa7Brio!Nzsi6AfJJQIssE3tLed42r5EKmR0PmlYozji6dVy16oPnVKLMTCsE87jNrIgx6hasnfy$
>     https://urldefense.com/v3/__https://bugzilla.kernel.org/show_bug.cgi?id=208045__;!!GqivPVa7Brio!Nzsi6AfJJQIssE3tLed42r5EKmR0PmlYozji6dVy16oPnVKLMTCsE87jNrIgx9cTxaSo$
> 
> All three patches together were tested on ARM with kernel
> 4.19.118 and 5.7.2 (see github issue and bugzilla).
> 
> ---
> v2: sent with a valid subject line.
> 

Acked-by: Mike Christie <michael.christie@oracle.com>
Martin K. Petersen June 20, 2020, 3:26 a.m. UTC | #2
On Thu, 18 Jun 2020 15:16:30 +0200, Bodo Stroesser wrote:

> This small series of patches consists of:
>    [PATCH 1/2 v2] scsi: target: tcmu: Optimize use of flush_dcache_page
>    [PATCH 2/2 v2] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range
> 
> Together with commit
>    8c4e0f212398 scsi: target: tcmu: Fix size in calls to tcmu_flush_dcache_range
> these patches fix crashes in tcmu on ARM.
> 
> [...]

Applied to 5.9/scsi-queue, thanks!

[1/2] scsi: target: tcmu: Optimize use of flush_dcache_page
      https://git.kernel.org/mkp/scsi/c/3c58f737231e
[2/2] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range on ARM
      https://git.kernel.org/mkp/scsi/c/3145550a7f8b
Bodo Stroesser Aug. 28, 2020, 8:43 a.m. UTC | #3
Hi,

I'm adding stable@vger.kernel.org

On 2020-06-20 05:26, Martin K. Petersen wrote:
> On Thu, 18 Jun 2020 15:16:30 +0200, Bodo Stroesser wrote:
> 
>> This small series of patches consists of:
>>     [PATCH 1/2 v2] scsi: target: tcmu: Optimize use of flush_dcache_page
>>     [PATCH 2/2 v2] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range
>>
>> Together with commit
>>     8c4e0f212398 scsi: target: tcmu: Fix size in calls to tcmu_flush_dcache_range
>> these patches fix crashes in tcmu on ARM.
>>
>> [...]
> 
> Applied to 5.9/scsi-queue, thanks!
> 
> [1/2] scsi: target: tcmu: Optimize use of flush_dcache_page
>        https://git.kernel.org/mkp/scsi/c/3c58f737231e
> [2/2] scsi: target: tcmu: Fix crash in tcmu_flush_dcache_range on ARM
>        https://git.kernel.org/mkp/scsi/c/3145550a7f8b
> 

Patch 2/2 of this series already made it into 5.8, (5.7,) 5.4 and 4.19,
but patch 1/2 was not added yet. The crash will be fixed with with both
patches only. So please consider adding patch 1/2 also. The full commit
is 3c58f737231e2c8cbf543a09d84d8c8e80e05e43

Thank you
Bodo