| Message ID | 20200818090638.26362-1-allen.lkml@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | dma: convert tasklets to use new tasklet_setup() | expand |
Hi Allen, On 18-08-20, 14:36, Allen Pais wrote: > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > introduced a new tasklet initialization API. This series converts > all the dma drivers to use the new tasklet_setup() API > > This is based on 5.9-rc1. > > Please pick this series, as I missed updating a couple of fixes and marking > the correct mailing list. The patches should have been tagged "dmaengine: ...". What is the status of this API conversion, I think I saw some discussions on API change, what is the conclusion? Thanks > > Allen Pais (35): > dma: altera-msgdma: convert tasklets to use new tasklet_setup() API > dma: at_hdmac: convert tasklets to use new tasklet_setup() API > dma: at_xdmac: convert tasklets to use new tasklet_setup() API > dma: coh901318: convert tasklets to use new tasklet_setup() API > dma: dw: convert tasklets to use new tasklet_setup() API > dma: ep93xx: convert tasklets to use new tasklet_setup() API > dma: fsl: convert tasklets to use new tasklet_setup() API > dma: imx-dma: convert tasklets to use new tasklet_setup() API > dma: ioat: convert tasklets to use new tasklet_setup() API > dma: iop_adma: convert tasklets to use new tasklet_setup() API > dma: ipu: convert tasklets to use new tasklet_setup() API > dma: k3dma: convert tasklets to use new tasklet_setup() API > dma: mediatek: convert tasklets to use new tasklet_setup() API > dma: mmp: convert tasklets to use new tasklet_setup() API > dma: mpc512x: convert tasklets to use new tasklet_setup() API > dma: mv_xor: convert tasklets to use new tasklet_setup() API > dma: mxs-dma: convert tasklets to use new tasklet_setup() API > dma: nbpfaxi: convert tasklets to use new tasklet_setup() API > dma: pch_dma: convert tasklets to use new tasklet_setup() API > dma: pl330: convert tasklets to use new tasklet_setup() API > dma: ppc4xx: convert tasklets to use new tasklet_setup() API > dma: qcom: convert tasklets to use new tasklet_setup() API > dma: sa11x0: convert tasklets to use new tasklet_setup() API > dma: sirf-dma: convert tasklets to use new tasklet_setup() API > dma: ste_dma40: convert tasklets to use new tasklet_setup() API > dma: sun6i: convert tasklets to use new tasklet_setup() API > dma: tegra20: convert tasklets to use new tasklet_setup() API > dma: timb_dma: convert tasklets to use new tasklet_setup() API > dma: txx9dmac: convert tasklets to use new tasklet_setup() API > dma: virt-dma: convert tasklets to use new tasklet_setup() API > dma: xgene: convert tasklets to use new tasklet_setup() API > dma: xilinx: convert tasklets to use new tasklet_setup() API > dma: plx_dma: convert tasklets to use new tasklet_setup() API > dma: sf-pdma: convert tasklets to use new tasklet_setup() API > dma: k3-udma: convert tasklets to use new tasklet_setup() API > > drivers/dma/altera-msgdma.c | 6 +++--- > drivers/dma/at_hdmac.c | 7 +++---- > drivers/dma/at_xdmac.c | 7 +++---- > drivers/dma/coh901318.c | 7 +++---- > drivers/dma/dw/core.c | 6 +++--- > drivers/dma/ep93xx_dma.c | 7 +++---- > drivers/dma/fsl_raid.c | 6 +++--- > drivers/dma/fsldma.c | 6 +++--- > drivers/dma/imx-dma.c | 7 +++---- > drivers/dma/ioat/dma.c | 6 +++--- > drivers/dma/ioat/dma.h | 2 +- > drivers/dma/ioat/init.c | 4 +--- > drivers/dma/iop-adma.c | 8 ++++---- > drivers/dma/ipu/ipu_idmac.c | 6 +++--- > drivers/dma/k3dma.c | 6 +++--- > drivers/dma/mediatek/mtk-cqdma.c | 7 +++---- > drivers/dma/mmp_pdma.c | 6 +++--- > drivers/dma/mmp_tdma.c | 6 +++--- > drivers/dma/mpc512x_dma.c | 6 +++--- > drivers/dma/mv_xor.c | 7 +++---- > drivers/dma/mv_xor_v2.c | 8 ++++---- > drivers/dma/mxs-dma.c | 7 +++---- > drivers/dma/nbpfaxi.c | 6 +++--- > drivers/dma/pch_dma.c | 7 +++---- > drivers/dma/pl330.c | 12 ++++++------ > drivers/dma/plx_dma.c | 7 +++---- > drivers/dma/ppc4xx/adma.c | 7 +++---- > drivers/dma/qcom/bam_dma.c | 6 +++--- > drivers/dma/qcom/hidma.c | 6 +++--- > drivers/dma/qcom/hidma_ll.c | 6 +++--- > drivers/dma/sa11x0-dma.c | 6 +++--- > drivers/dma/sf-pdma/sf-pdma.c | 14 ++++++-------- > drivers/dma/sirf-dma.c | 6 +++--- > drivers/dma/ste_dma40.c | 7 +++---- > drivers/dma/sun6i-dma.c | 6 +++--- > drivers/dma/tegra20-apb-dma.c | 7 +++---- > drivers/dma/ti/k3-udma.c | 7 +++---- > drivers/dma/timb_dma.c | 6 +++--- > drivers/dma/txx9dmac.c | 14 ++++++-------- > drivers/dma/virt-dma.c | 6 +++--- > drivers/dma/xgene-dma.c | 7 +++---- > drivers/dma/xilinx/xilinx_dma.c | 7 +++---- > drivers/dma/xilinx/zynqmp_dma.c | 6 +++--- > 43 files changed, 136 insertions(+), 158 deletions(-) > > -- > 2.17.1
Vinod, > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > > introduced a new tasklet initialization API. This series converts > > all the dma drivers to use the new tasklet_setup() API > > > > This is based on 5.9-rc1. > > > > Please pick this series, as I missed updating a couple of fixes and marking > > the correct mailing list. > > The patches should have been tagged "dmaengine: ...". My bad, Will have it fixed. > > What is the status of this API conversion, I think I saw some > discussions on API change, what is the conclusion? Yes, the updated API should land into Linus's tree shortly. Will send out V2 with the new API soon. Thanks. > Thanks > > > > > Allen Pais (35): > > dma: altera-msgdma: convert tasklets to use new tasklet_setup() API > > dma: at_hdmac: convert tasklets to use new tasklet_setup() API > > dma: at_xdmac: convert tasklets to use new tasklet_setup() API > > dma: coh901318: convert tasklets to use new tasklet_setup() API > > dma: dw: convert tasklets to use new tasklet_setup() API > > dma: ep93xx: convert tasklets to use new tasklet_setup() API > > dma: fsl: convert tasklets to use new tasklet_setup() API > > dma: imx-dma: convert tasklets to use new tasklet_setup() API > > dma: ioat: convert tasklets to use new tasklet_setup() API > > dma: iop_adma: convert tasklets to use new tasklet_setup() API > > dma: ipu: convert tasklets to use new tasklet_setup() API > > dma: k3dma: convert tasklets to use new tasklet_setup() API > > dma: mediatek: convert tasklets to use new tasklet_setup() API > > dma: mmp: convert tasklets to use new tasklet_setup() API > > dma: mpc512x: convert tasklets to use new tasklet_setup() API > > dma: mv_xor: convert tasklets to use new tasklet_setup() API > > dma: mxs-dma: convert tasklets to use new tasklet_setup() API > > dma: nbpfaxi: convert tasklets to use new tasklet_setup() API > > dma: pch_dma: convert tasklets to use new tasklet_setup() API > > dma: pl330: convert tasklets to use new tasklet_setup() API > > dma: ppc4xx: convert tasklets to use new tasklet_setup() API > > dma: qcom: convert tasklets to use new tasklet_setup() API > > dma: sa11x0: convert tasklets to use new tasklet_setup() API > > dma: sirf-dma: convert tasklets to use new tasklet_setup() API > > dma: ste_dma40: convert tasklets to use new tasklet_setup() API > > dma: sun6i: convert tasklets to use new tasklet_setup() API > > dma: tegra20: convert tasklets to use new tasklet_setup() API > > dma: timb_dma: convert tasklets to use new tasklet_setup() API > > dma: txx9dmac: convert tasklets to use new tasklet_setup() API > > dma: virt-dma: convert tasklets to use new tasklet_setup() API > > dma: xgene: convert tasklets to use new tasklet_setup() API > > dma: xilinx: convert tasklets to use new tasklet_setup() API > > dma: plx_dma: convert tasklets to use new tasklet_setup() API > > dma: sf-pdma: convert tasklets to use new tasklet_setup() API > > dma: k3-udma: convert tasklets to use new tasklet_setup() API > > > > drivers/dma/altera-msgdma.c | 6 +++--- > > drivers/dma/at_hdmac.c | 7 +++---- > > drivers/dma/at_xdmac.c | 7 +++---- > > drivers/dma/coh901318.c | 7 +++---- > > drivers/dma/dw/core.c | 6 +++--- > > drivers/dma/ep93xx_dma.c | 7 +++---- > > drivers/dma/fsl_raid.c | 6 +++--- > > drivers/dma/fsldma.c | 6 +++--- > > drivers/dma/imx-dma.c | 7 +++---- > > drivers/dma/ioat/dma.c | 6 +++--- > > drivers/dma/ioat/dma.h | 2 +- > > drivers/dma/ioat/init.c | 4 +--- > > drivers/dma/iop-adma.c | 8 ++++---- > > drivers/dma/ipu/ipu_idmac.c | 6 +++--- > > drivers/dma/k3dma.c | 6 +++--- > > drivers/dma/mediatek/mtk-cqdma.c | 7 +++---- > > drivers/dma/mmp_pdma.c | 6 +++--- > > drivers/dma/mmp_tdma.c | 6 +++--- > > drivers/dma/mpc512x_dma.c | 6 +++--- > > drivers/dma/mv_xor.c | 7 +++---- > > drivers/dma/mv_xor_v2.c | 8 ++++---- > > drivers/dma/mxs-dma.c | 7 +++---- > > drivers/dma/nbpfaxi.c | 6 +++--- > > drivers/dma/pch_dma.c | 7 +++---- > > drivers/dma/pl330.c | 12 ++++++------ > > drivers/dma/plx_dma.c | 7 +++---- > > drivers/dma/ppc4xx/adma.c | 7 +++---- > > drivers/dma/qcom/bam_dma.c | 6 +++--- > > drivers/dma/qcom/hidma.c | 6 +++--- > > drivers/dma/qcom/hidma_ll.c | 6 +++--- > > drivers/dma/sa11x0-dma.c | 6 +++--- > > drivers/dma/sf-pdma/sf-pdma.c | 14 ++++++-------- > > drivers/dma/sirf-dma.c | 6 +++--- > > drivers/dma/ste_dma40.c | 7 +++---- > > drivers/dma/sun6i-dma.c | 6 +++--- > > drivers/dma/tegra20-apb-dma.c | 7 +++---- > > drivers/dma/ti/k3-udma.c | 7 +++---- > > drivers/dma/timb_dma.c | 6 +++--- > > drivers/dma/txx9dmac.c | 14 ++++++-------- > > drivers/dma/virt-dma.c | 6 +++--- > > drivers/dma/xgene-dma.c | 7 +++---- > > drivers/dma/xilinx/xilinx_dma.c | 7 +++---- > > drivers/dma/xilinx/zynqmp_dma.c | 6 +++--- > > 43 files changed, 136 insertions(+), 158 deletions(-) > > > > -- > > 2.17.1 > > -- > ~Vinod
Hi Allen, On 26-08-20, 06:41, Allen wrote: > Vinod, > > > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > > > introduced a new tasklet initialization API. This series converts > > > all the dma drivers to use the new tasklet_setup() API > > > > > > This is based on 5.9-rc1. > > > > > > Please pick this series, as I missed updating a couple of fixes and marking > > > the correct mailing list. > > > > The patches should have been tagged "dmaengine: ...". > > My bad, Will have it fixed. > > > > > What is the status of this API conversion, I think I saw some > > discussions on API change, what is the conclusion? > > Yes, the updated API should land into Linus's tree shortly. > Will send out V2 with the new API soon. Thanks for update
Vinod, > > > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > > > > introduced a new tasklet initialization API. This series converts > > > > all the dma drivers to use the new tasklet_setup() API > > > > > > > > This is based on 5.9-rc1. > > > > > > > > Please pick this series, as I missed updating a couple of fixes and marking > > > > the correct mailing list. > > > > > > The patches should have been tagged "dmaengine: ...". > > > > My bad, Will have it fixed. > > > > > > > > What is the status of this API conversion, I think I saw some > > > discussions on API change, what is the conclusion? > > > > Yes, the updated API should land into Linus's tree shortly. > > Will send out V2 with the new API soon. > > Thanks for update We weren't successful in getting the new API accepted. We will be sticking to from_tasklet() unless you as a maintainer object to it. If there's no objection, please let me know if I can send out V2 with subject line fixed. Thanks, Allen
On 31-08-20, 11:30, Allen wrote: > Vinod, > > > > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > > > > > introduced a new tasklet initialization API. This series converts > > > > > all the dma drivers to use the new tasklet_setup() API > > > > > > > > > > This is based on 5.9-rc1. > > > > > > > > > > Please pick this series, as I missed updating a couple of fixes and marking > > > > > the correct mailing list. > > > > > > > > The patches should have been tagged "dmaengine: ...". > > > > > > My bad, Will have it fixed. > > > > > > > > > > > What is the status of this API conversion, I think I saw some > > > > discussions on API change, what is the conclusion? > > > > > > Yes, the updated API should land into Linus's tree shortly. > > > Will send out V2 with the new API soon. > > > > Thanks for update > > We weren't successful in getting the new API accepted. We will be > sticking to from_tasklet() unless you as a maintainer object to it. Ok, but is the colclusion to keep from_tasklet() or move to something else later on. If that is the case, I would like to see the change once only > If there's no objection, please let me know if I can send out V2 > with subject line fixed. If this wont change, then yes please
> > > > > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > > > > > > introduced a new tasklet initialization API. This series converts > > > > > > all the dma drivers to use the new tasklet_setup() API > > > > > > > > > > > > This is based on 5.9-rc1. > > > > > > > > > > > > Please pick this series, as I missed updating a couple of fixes and marking > > > > > > the correct mailing list. > > > > > > > > > > The patches should have been tagged "dmaengine: ...". > > > > > > > > My bad, Will have it fixed. > > > > > > > > > > > > > > What is the status of this API conversion, I think I saw some > > > > > discussions on API change, what is the conclusion? > > > > > > > > Yes, the updated API should land into Linus's tree shortly. > > > > Will send out V2 with the new API soon. > > > > > > Thanks for update > > > > We weren't successful in getting the new API accepted. We will be > > sticking to from_tasklet() unless you as a maintainer object to it. > > > Ok, but is the colclusion to keep from_tasklet() or move to something > else later on. If that is the case, I would like to see the change once > only No, we won't be moving to something else. It's either from_tasklet() or to use container_of()(which could lead to longer lines). > > If there's no objection, please let me know if I can send out V2 > > with subject line fixed. > > If this wont change, then yes please Will prep V2 and send it out soon. Thanks.
Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the dma drivers to use the new tasklet_setup() API This is based on 5.9-rc1. Please pick this series, as I missed updating a couple of fixes and marking the correct mailing list. Allen Pais (35): dma: altera-msgdma: convert tasklets to use new tasklet_setup() API dma: at_hdmac: convert tasklets to use new tasklet_setup() API dma: at_xdmac: convert tasklets to use new tasklet_setup() API dma: coh901318: convert tasklets to use new tasklet_setup() API dma: dw: convert tasklets to use new tasklet_setup() API dma: ep93xx: convert tasklets to use new tasklet_setup() API dma: fsl: convert tasklets to use new tasklet_setup() API dma: imx-dma: convert tasklets to use new tasklet_setup() API dma: ioat: convert tasklets to use new tasklet_setup() API dma: iop_adma: convert tasklets to use new tasklet_setup() API dma: ipu: convert tasklets to use new tasklet_setup() API dma: k3dma: convert tasklets to use new tasklet_setup() API dma: mediatek: convert tasklets to use new tasklet_setup() API dma: mmp: convert tasklets to use new tasklet_setup() API dma: mpc512x: convert tasklets to use new tasklet_setup() API dma: mv_xor: convert tasklets to use new tasklet_setup() API dma: mxs-dma: convert tasklets to use new tasklet_setup() API dma: nbpfaxi: convert tasklets to use new tasklet_setup() API dma: pch_dma: convert tasklets to use new tasklet_setup() API dma: pl330: convert tasklets to use new tasklet_setup() API dma: ppc4xx: convert tasklets to use new tasklet_setup() API dma: qcom: convert tasklets to use new tasklet_setup() API dma: sa11x0: convert tasklets to use new tasklet_setup() API dma: sirf-dma: convert tasklets to use new tasklet_setup() API dma: ste_dma40: convert tasklets to use new tasklet_setup() API dma: sun6i: convert tasklets to use new tasklet_setup() API dma: tegra20: convert tasklets to use new tasklet_setup() API dma: timb_dma: convert tasklets to use new tasklet_setup() API dma: txx9dmac: convert tasklets to use new tasklet_setup() API dma: virt-dma: convert tasklets to use new tasklet_setup() API dma: xgene: convert tasklets to use new tasklet_setup() API dma: xilinx: convert tasklets to use new tasklet_setup() API dma: plx_dma: convert tasklets to use new tasklet_setup() API dma: sf-pdma: convert tasklets to use new tasklet_setup() API dma: k3-udma: convert tasklets to use new tasklet_setup() API drivers/dma/altera-msgdma.c | 6 +++--- drivers/dma/at_hdmac.c | 7 +++---- drivers/dma/at_xdmac.c | 7 +++---- drivers/dma/coh901318.c | 7 +++---- drivers/dma/dw/core.c | 6 +++--- drivers/dma/ep93xx_dma.c | 7 +++---- drivers/dma/fsl_raid.c | 6 +++--- drivers/dma/fsldma.c | 6 +++--- drivers/dma/imx-dma.c | 7 +++---- drivers/dma/ioat/dma.c | 6 +++--- drivers/dma/ioat/dma.h | 2 +- drivers/dma/ioat/init.c | 4 +--- drivers/dma/iop-adma.c | 8 ++++---- drivers/dma/ipu/ipu_idmac.c | 6 +++--- drivers/dma/k3dma.c | 6 +++--- drivers/dma/mediatek/mtk-cqdma.c | 7 +++---- drivers/dma/mmp_pdma.c | 6 +++--- drivers/dma/mmp_tdma.c | 6 +++--- drivers/dma/mpc512x_dma.c | 6 +++--- drivers/dma/mv_xor.c | 7 +++---- drivers/dma/mv_xor_v2.c | 8 ++++---- drivers/dma/mxs-dma.c | 7 +++---- drivers/dma/nbpfaxi.c | 6 +++--- drivers/dma/pch_dma.c | 7 +++---- drivers/dma/pl330.c | 12 ++++++------ drivers/dma/plx_dma.c | 7 +++---- drivers/dma/ppc4xx/adma.c | 7 +++---- drivers/dma/qcom/bam_dma.c | 6 +++--- drivers/dma/qcom/hidma.c | 6 +++--- drivers/dma/qcom/hidma_ll.c | 6 +++--- drivers/dma/sa11x0-dma.c | 6 +++--- drivers/dma/sf-pdma/sf-pdma.c | 14 ++++++-------- drivers/dma/sirf-dma.c | 6 +++--- drivers/dma/ste_dma40.c | 7 +++---- drivers/dma/sun6i-dma.c | 6 +++--- drivers/dma/tegra20-apb-dma.c | 7 +++---- drivers/dma/ti/k3-udma.c | 7 +++---- drivers/dma/timb_dma.c | 6 +++--- drivers/dma/txx9dmac.c | 14 ++++++-------- drivers/dma/virt-dma.c | 6 +++--- drivers/dma/xgene-dma.c | 7 +++---- drivers/dma/xilinx/xilinx_dma.c | 7 +++---- drivers/dma/xilinx/zynqmp_dma.c | 6 +++--- 43 files changed, 136 insertions(+), 158 deletions(-)