| Message ID | 20200902193658.20539-1-krzk@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: Minor cleanups and compile test | expand |
On Wed, 2 Sep 2020 at 21:37, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Hi, > > Set of minor cleanups. Patches requiring more attention: > - 6/11: Testing and review would be appreciated, > - 11/11: I build tested multiple architectures but not all and > definitely no all possible configs. This one could sit on the lists > for few days so 0-day would try it. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (11): > mmc: bcm2835: Simplify with dev_err_probe() > mmc: davinci: Simplify with dev_err_probe() > mmc: dw_mmc-zx: Simplify with dev_err_probe() > mmc: jz4740: Simplify with dev_err_probe() > mmc: meson: Simplify with dev_err_probe() > mmc: sdhci-brcmstb: Simplify with optional clock and dev_err_probe() > mmc: sdhci-of-arasan: Simplify with dev_err_probe() > mmc: sdhci-tegra: Simplify with dev_err_probe() > mmc: dw_mmc: Simplify with dev_err_probe() > mmc: sdhci-of-sparx5: Use proper printk format for dma_addr_t > mmc: host: Enable compile testing of multiple drivers > > drivers/mmc/host/Kconfig | 42 ++++++++++++++++-------------- > drivers/mmc/host/bcm2835.c | 4 +-- > drivers/mmc/host/davinci_mmc.c | 5 ++-- > drivers/mmc/host/dw_mmc-zx.c | 11 +++----- > drivers/mmc/host/dw_mmc.c | 9 +++---- > drivers/mmc/host/jz4740_mmc.c | 5 ++-- > drivers/mmc/host/meson-gx-mmc.c | 16 ++++-------- > drivers/mmc/host/sdhci-brcmstb.c | 12 ++++----- > drivers/mmc/host/sdhci-of-arasan.c | 7 +++-- > drivers/mmc/host/sdhci-of-sparx5.c | 4 +-- > drivers/mmc/host/sdhci-tegra.c | 7 ++--- > 11 files changed, 51 insertions(+), 71 deletions(-) > > -- > 2.17.1 > Series applied for next, except 11, thanks! Kind regards Uffe
On Thu, 3 Sep 2020 at 10:10, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > Series applied for next, except 11, thanks! Thanks. I will fix pointed compile-test issues and send later a follow up, also removing the MMC dependency as pointed by Michał. Best regards, Krzysztof
On Thu, Sep 3, 2020 at 2:40 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Wed, 2 Sep 2020 at 21:37, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > Hi, > > > > Set of minor cleanups. Patches requiring more attention: > > - 6/11: Testing and review would be appreciated, > > - 11/11: I build tested multiple architectures but not all and > > definitely no all possible configs. This one could sit on the lists > > for few days so 0-day would try it. > > > > Best regards, > > Krzysztof > > > > Krzysztof Kozlowski (11): > > mmc: bcm2835: Simplify with dev_err_probe() > > mmc: davinci: Simplify with dev_err_probe() > > mmc: dw_mmc-zx: Simplify with dev_err_probe() > > mmc: jz4740: Simplify with dev_err_probe() > > mmc: meson: Simplify with dev_err_probe() > > mmc: sdhci-brcmstb: Simplify with optional clock and dev_err_probe() > > mmc: sdhci-of-arasan: Simplify with dev_err_probe() > > mmc: sdhci-tegra: Simplify with dev_err_probe() > > mmc: dw_mmc: Simplify with dev_err_probe() > > mmc: sdhci-of-sparx5: Use proper printk format for dma_addr_t > > mmc: host: Enable compile testing of multiple drivers > > > > drivers/mmc/host/Kconfig | 42 ++++++++++++++++-------------- > > drivers/mmc/host/bcm2835.c | 4 +-- > > drivers/mmc/host/davinci_mmc.c | 5 ++-- > > drivers/mmc/host/dw_mmc-zx.c | 11 +++----- > > drivers/mmc/host/dw_mmc.c | 9 +++---- > > drivers/mmc/host/jz4740_mmc.c | 5 ++-- > > drivers/mmc/host/meson-gx-mmc.c | 16 ++++-------- > > drivers/mmc/host/sdhci-brcmstb.c | 12 ++++----- > > drivers/mmc/host/sdhci-of-arasan.c | 7 +++-- > > drivers/mmc/host/sdhci-of-sparx5.c | 4 +-- > > drivers/mmc/host/sdhci-tegra.c | 7 ++--- > > 11 files changed, 51 insertions(+), 71 deletions(-) > > > > -- > > 2.17.1 > > > > Series applied for next, except 11, thanks! I see there's a bunch of these already, but I think we can do better here than dev_err_probe. We have _optional variants for the case not getting a resource is not an error. So the called functions like devm_clk_get can print an error. We already have this for platform_get_irq along with a coccinelle script to fix cases. I have a WIP branch[1] doing this. Rob [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dev_err-removal
On Fri, 11 Sep 2020 at 00:55, Rob Herring <robh@kernel.org> wrote: > > On Thu, Sep 3, 2020 at 2:40 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > On Wed, 2 Sep 2020 at 21:37, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > Hi, > > > > > > Set of minor cleanups. Patches requiring more attention: > > > - 6/11: Testing and review would be appreciated, > > > - 11/11: I build tested multiple architectures but not all and > > > definitely no all possible configs. This one could sit on the lists > > > for few days so 0-day would try it. > > > > > > Best regards, > > > Krzysztof > > > > > > Krzysztof Kozlowski (11): > > > mmc: bcm2835: Simplify with dev_err_probe() > > > mmc: davinci: Simplify with dev_err_probe() > > > mmc: dw_mmc-zx: Simplify with dev_err_probe() > > > mmc: jz4740: Simplify with dev_err_probe() > > > mmc: meson: Simplify with dev_err_probe() > > > mmc: sdhci-brcmstb: Simplify with optional clock and dev_err_probe() > > > mmc: sdhci-of-arasan: Simplify with dev_err_probe() > > > mmc: sdhci-tegra: Simplify with dev_err_probe() > > > mmc: dw_mmc: Simplify with dev_err_probe() > > > mmc: sdhci-of-sparx5: Use proper printk format for dma_addr_t > > > mmc: host: Enable compile testing of multiple drivers > > > > > > drivers/mmc/host/Kconfig | 42 ++++++++++++++++-------------- > > > drivers/mmc/host/bcm2835.c | 4 +-- > > > drivers/mmc/host/davinci_mmc.c | 5 ++-- > > > drivers/mmc/host/dw_mmc-zx.c | 11 +++----- > > > drivers/mmc/host/dw_mmc.c | 9 +++---- > > > drivers/mmc/host/jz4740_mmc.c | 5 ++-- > > > drivers/mmc/host/meson-gx-mmc.c | 16 ++++-------- > > > drivers/mmc/host/sdhci-brcmstb.c | 12 ++++----- > > > drivers/mmc/host/sdhci-of-arasan.c | 7 +++-- > > > drivers/mmc/host/sdhci-of-sparx5.c | 4 +-- > > > drivers/mmc/host/sdhci-tegra.c | 7 ++--- > > > 11 files changed, 51 insertions(+), 71 deletions(-) > > > > > > -- > > > 2.17.1 > > > > > > > Series applied for next, except 11, thanks! > > I see there's a bunch of these already, but I think we can do better > here than dev_err_probe. We have _optional variants for the case not > getting a resource is not an error. So the called functions like > devm_clk_get can print an error. We already have this for > platform_get_irq along with a coccinelle script to fix cases. I have a > WIP branch[1] doing this. That's quite good idea. Best regards, Krzysztof