| Message ID | 20200831082917.17117-6-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Add Engicam PX30.Core | expand |
On Mon, 31 Aug 2020 13:59:15 +0530, Jagan Teki wrote: > PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam. > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > touch interface support. > > PX30.Core needs to mount on top of this Carrier board for creating > complete PX30.Core C.TOUCH 2.0 board. > > Add bindings for it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v3: > - none > Changes for v2: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On Thu, Sep 3, 2020 at 9:55 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, 31 Aug 2020 13:59:15 +0530, Jagan Teki wrote: > > PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam. > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > > touch interface support. > > > > PX30.Core needs to mount on top of this Carrier board for creating > > complete PX30.Core C.TOUCH 2.0 board. > > > > Add bindings for it. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v3: > > - none > > Changes for v2: > > - new patch > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. Yes, it's on purpose. The previous binding was about C.TOUCH with LVDS board and this one is C.TOUCH carrier only. ie the main reason I have not included. I did mention in the cover-letter saying previous one dropped and the C.TOUCH carrier added. Hope this answers your query. Jagan.
On Thu, Sep 3, 2020 at 10:47 AM Jagan Teki <jagan@amarulasolutions.com> wrote: > > On Thu, Sep 3, 2020 at 9:55 PM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, 31 Aug 2020 13:59:15 +0530, Jagan Teki wrote: > > > PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam. > > > > > > C.TOUCH 2.0 is a general purpose carrier board with capacitive > > > touch interface support. > > > > > > PX30.Core needs to mount on top of this Carrier board for creating > > > complete PX30.Core C.TOUCH 2.0 board. > > > > > > Add bindings for it. > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > --- > > > Changes for v3: > > > - none > > > Changes for v2: > > > - new patch > > > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > > there's no need to repost patches *only* to add the tags. The upstream > > maintainer will do that for acks received on the version they apply. > > > > If a tag was not added on purpose, please state why and what changed. > > Yes, it's on purpose. The previous binding was about C.TOUCH with LVDS > board and this one is C.TOUCH carrier only. ie the main reason I have > not included. I did mention in the cover-letter saying previous one > dropped and the C.TOUCH carrier added. The changelog here says no changes... Anyways, Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index bda0f2781890..3aecb1241492 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -70,6 +70,12 @@ properties: - const: elgin,rv1108-r1 - const: rockchip,rv1108 + - description: Engicam PX30.Core C.TOUCH 2.0 + items: + - const: engicam,px30-core-ctouch2 + - const: engicam,px30-px30-core + - const: rockchip,px30 + - description: Engicam PX30.Core EDIMM2.2 Starter Kit items: - const: engicam,px30-core-edimm2.2
PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam. C.TOUCH 2.0 is a general purpose carrier board with capacitive touch interface support. PX30.Core needs to mount on top of this Carrier board for creating complete PX30.Core C.TOUCH 2.0 board. Add bindings for it. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v3: - none Changes for v2: - new patch Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ 1 file changed, 6 insertions(+)