diff mbox series

drm/komeda: Drop local dma_parms

Message ID 8de297b5b916628c77b99068fb5aac1a69eed6f5.1599164796.git.robin.murphy@arm.com (mailing list archive)
State New, archived
Headers show
Series drm/komeda: Drop local dma_parms | expand

Commit Message

Robin Murphy Sept. 3, 2020, 8:36 p.m. UTC 
Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
for platform devices"), struct platform_device already provides a
dma_parms structure, so we can save allocating another one.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---

FYI, get_maintainer.pl seems to be choking on your L: entry somehow,
since it just shows " (open list:ARM KOMEDA DRM-KMS DRIVER)" without the
description or address, not sure what's up with that.

 drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
 drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 --
 2 files changed, 3 deletions(-)

--
2.28.0.dirty

Comments

Robin Murphy Sept. 3, 2020, 9:26 p.m. UTC | #1 
On 2020-09-03 21:36, Robin Murphy wrote:
> Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
> for platform devices"), struct platform_device already provides a
> dma_parms structure, so we can save allocating another one.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> 
> FYI, get_maintainer.pl seems to be choking on your L: entry somehow,
> since it just shows " (open list:ARM KOMEDA DRM-KMS DRIVER)" without the
> description or address, not sure what's up with that.
> 
>   drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
>   drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 --
>   2 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 1d767473ba8a..e7bb905062d9 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -261,7 +261,6 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
>   		goto disable_clk;
>   	}
> 
> -	dev->dma_parms = &mdev->dma_parms;
>   	dma_set_max_seg_size(dev, DMA_BIT_MASK(32));

Oops, I missed my "Also the DMA segment size is simply a size, not a 
bitmask" bit here - ideally this should be changed to UINT_MAX while 
we're cleaning up. Maybe that could just be fixed up when applying, but 
let me know if you'd like a resend.

Cheers,
Robin.

>   	mdev->iommu = iommu_get_domain_for_dev(mdev->dev);
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> index ce27f2f27c24..5b536f0cb548 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -163,8 +163,6 @@ struct komeda_dev {
>   	struct device *dev;
>   	/** @reg_base: the base address of komeda io space */
>   	u32 __iomem   *reg_base;
> -	/** @dma_parms: the dma parameters of komeda */
> -	struct device_dma_parameters dma_parms;
> 
>   	/** @chip: the basic chip information */
>   	struct komeda_chip_info chip;
> --
> 2.28.0.dirty
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
James Qian Wang Sept. 14, 2020, 4:41 a.m. UTC | #2 
On Thu, Sep 03, 2020 at 10:26:50PM +0100, Robin Murphy wrote:
> On 2020-09-03 21:36, Robin Murphy wrote:
> > Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
> > for platform devices"), struct platform_device already provides a
> > dma_parms structure, so we can save allocating another one.
> > 
> > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> > ---
> > 
> > FYI, get_maintainer.pl seems to be choking on your L: entry somehow,
> > since it just shows " (open list:ARM KOMEDA DRM-KMS DRIVER)" without the
> > description or address, not sure what's up with that.
> > 
> >   drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
> >   drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 --
> >   2 files changed, 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > index 1d767473ba8a..e7bb905062d9 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -261,7 +261,6 @@ struct komeda_dev *komeda_dev_create(struct device *dev)
> >   		goto disable_clk;
> >   	}
> > 
> > -	dev->dma_parms = &mdev->dma_parms;
> >   	dma_set_max_seg_size(dev, DMA_BIT_MASK(32));
> 
> Oops, I missed my "Also the DMA segment size is simply a size, not a
> bitmask" bit here - ideally this should be changed to UINT_MAX while we're
> cleaning up. Maybe that could just be fixed up when applying, but let me
> know if you'd like a resend.

Don't worry, I can fix it when applying. :)

And thank you for this patch.

Reviewed-by: James Qian Wang <james.qian.wang@arm.com>

> Cheers,
> Robin.
> 
> >   	mdev->iommu = iommu_get_domain_for_dev(mdev->dev);
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> > index ce27f2f27c24..5b536f0cb548 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> > @@ -163,8 +163,6 @@ struct komeda_dev {
> >   	struct device *dev;
> >   	/** @reg_base: the base address of komeda io space */
> >   	u32 __iomem   *reg_base;
> > -	/** @dma_parms: the dma parameters of komeda */
> > -	struct device_dma_parameters dma_parms;
> > 
> >   	/** @chip: the basic chip information */
> >   	struct komeda_chip_info chip;
> > --
> > 2.28.0.dirty
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
diff mbox series

Patch

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 1d767473ba8a..e7bb905062d9 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -261,7 +261,6 @@  struct komeda_dev *komeda_dev_create(struct device *dev)
 		goto disable_clk;
 	}

-	dev->dma_parms = &mdev->dma_parms;
 	dma_set_max_seg_size(dev, DMA_BIT_MASK(32));

 	mdev->iommu = iommu_get_domain_for_dev(mdev->dev);
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
index ce27f2f27c24..5b536f0cb548 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
@@ -163,8 +163,6 @@  struct komeda_dev {
 	struct device *dev;
 	/** @reg_base: the base address of komeda io space */
 	u32 __iomem   *reg_base;
-	/** @dma_parms: the dma parameters of komeda */
-	struct device_dma_parameters dma_parms;

 	/** @chip: the basic chip information */
 	struct komeda_chip_info chip;