| Message ID | 20200903131029.18334-4-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | dt-bindings: media: ov772x: Convert to json-schema | expand |
Hi Jacopo, Thank you for the patch. On Thu, Sep 03, 2020 at 03:10:29PM +0200, Jacopo Mondi wrote: > Document endpoint properties for the parallel bus type and > add them to the example. > > Specify a few constraints: > - If the bus type is BT.656 no hsync or vsycn polarities can be s/vsycn/vsync/ > specified. > - If the bus width is 10 bits, not data-shift can be applied. > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../bindings/media/i2c/ovti,ov772x.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > index 406e9cd463a2..c596cbd1e92d 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml > @@ -52,6 +52,45 @@ properties: > bus-type: > enum: [5, 6] > > + bus-width: > + enum: [8, 10] > + default: 10 > + > + data-shift: > + enum: [0, 2] > + default: 0 > + > + hsync-active: > + enum: [0, 1] > + default: 1 > + > + vsync-active: > + enum: [0, 1] > + default: 1 > + > + pclk-sample: > + enum: [0, 1] > + default: 1 > + > + allOf: > + - if: > + properties: > + bus-type: > + const: 6 > + then: > + properties: > + hsync-active: false > + vsync-active: false > + This should eventually end up in video-interfaces.yaml. I don't mind keeping it here in the meantime. Same for the hsync-active, vsync-active and pclk-sample enum, they should end up in video-interfaces.yaml. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + - if: > + properties: > + bus-width: > + const: 10 > + then: > + properties: > + data-shift: > + const: 0 > + > required: > - remote-endpoint > - bus-type > @@ -85,6 +124,11 @@ examples: > port { > ov772x_0: endpoint { > bus-type = <5>; > + vsync-active = <0>; > + hsync-active = <0>; > + pclk-sample = <0>; > + bus-width = <8>; > + data-shift = <0>; > remote-endpoint = <&vcap1_in0>; > }; > };
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml index 406e9cd463a2..c596cbd1e92d 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml @@ -52,6 +52,45 @@ properties: bus-type: enum: [5, 6] + bus-width: + enum: [8, 10] + default: 10 + + data-shift: + enum: [0, 2] + default: 0 + + hsync-active: + enum: [0, 1] + default: 1 + + vsync-active: + enum: [0, 1] + default: 1 + + pclk-sample: + enum: [0, 1] + default: 1 + + allOf: + - if: + properties: + bus-type: + const: 6 + then: + properties: + hsync-active: false + vsync-active: false + + - if: + properties: + bus-width: + const: 10 + then: + properties: + data-shift: + const: 0 + required: - remote-endpoint - bus-type @@ -85,6 +124,11 @@ examples: port { ov772x_0: endpoint { bus-type = <5>; + vsync-active = <0>; + hsync-active = <0>; + pclk-sample = <0>; + bus-width = <8>; + data-shift = <0>; remote-endpoint = <&vcap1_in0>; }; };