| Message ID | 20200903220622.504-1-luoyonggang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | configure: the error info not consistence with option. | expand |
> > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user > if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then > - error_exit "--enable-vhost-net-user requires --enable-vhost-user" > + error_exit "--enable-vhost-net requires --enable-vhost-user" > fi > This change seems wrong. Paolo test "$vhost_crypto" = "" && vhost_crypto=$vhost_user > if test "$vhost_crypto" = "yes" && test "$vhost_user" = "no"; then > -- > 2.28.0.windows.1 > >
On Fri, Sep 4, 2020 at 8:18 AM Paolo Bonzini <pbonzini@redhat.com> wrote: > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user >> if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then >> - error_exit "--enable-vhost-net-user requires --enable-vhost-user" >> + error_exit "--enable-vhost-net requires --enable-vhost-user" >> fi >> > > This change seems wrong. > I didn't found --enable-vhost-net-user option handling? you may grep it? > > Paolo > > test "$vhost_crypto" = "" && vhost_crypto=$vhost_user >> if test "$vhost_crypto" = "yes" && test "$vhost_user" = "no"; then >> -- >> 2.28.0.windows.1 >> >>
On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote: > > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user > if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; > then > - error_exit "--enable-vhost-net-user requires --enable-vhost-user" > + error_exit "--enable-vhost-net requires --enable-vhost-user" > fi > > > This change seems wrong. > > I didn't found --enable-vhost-net-user option handling? > you may grep it? > > You're right, it is all dead code. The four lines are equivalent to just vhost_net_user=$vhost_user. You could also add --enable-vhost-net-user though! Thanks, Paolo
On Fri, Sep 4, 2020 at 3:54 PM Paolo Bonzini <pbonzini@redhat.com> wrote: > On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote: > > > > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user > > if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; > > then > > - error_exit "--enable-vhost-net-user requires > --enable-vhost-user" > > + error_exit "--enable-vhost-net requires --enable-vhost-user" > > fi > > > > > > This change seems wrong. > > > > I didn't found --enable-vhost-net-user option handling? > > you may grep it? > > > > > > You're right, it is all dead code. The four lines are equivalent to > just vhost_net_user=$vhost_user. You could also add > --enable-vhost-net-user though! > I remove those four lines and use vhost_net_user=$vhost_user instead for simplicity, if we have no strong need of this option, i guess remove it are better > > Thanks, > > Paolo > >
diff --git a/configure b/configure index e42d210e5f..ae63c4fd54 100755 --- a/configure +++ b/configure @@ -2545,7 +2545,7 @@ fi # vhost-user backends test "$vhost_net_user" = "" && vhost_net_user=$vhost_user if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; then - error_exit "--enable-vhost-net-user requires --enable-vhost-user" + error_exit "--enable-vhost-net requires --enable-vhost-user" fi test "$vhost_crypto" = "" && vhost_crypto=$vhost_user if test "$vhost_crypto" = "yes" && test "$vhost_user" = "no"; then
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)