| Message ID | 20200830174410.256533-1-rodrigosiqueiramelo@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for testing writeback connectors | expand |
On Sun, Aug 30, 2020 at 01:44:06PM -0400, Rodrigo Siqueira wrote: > Hi, Hi, Can this series be merged? Neither me nor Brian managed to get accepted in the i-g-t committers list, so I cannot push it. Best regards, Liviu > > A couple of months ago I updated and re-submitted a patchset made by > Brian Starkey and Liviu Dudau for adding a writeback connectors test to > IGT. It is important to highlight that DRM already have writeback > connectors support, which is a way to expose in DRM the hardware > functionality from display engines that allows writing back into memory > the result of DE's composition of supported planes. > > After I resubmitted the patchset, Simon Ser provides a long and detailed > review for all of the patches (thanks Simon). Additionally, Maxime > Ripard tested the previous series in an ARM32 architecture and provided > his feedback for making this patchset portable (thanks Maxime). I > finally had time to go through all the details and prepare this new > version. Follows some notes: > > 1. Patchset author > > Brian Starkey is the original author of this patchset, and I'm just > trying to upstream his changes. Note that during this patch submission, > the mail server from google going to overwrite Brian's mail by mine; > this happens on the mail server side for avoiding malicious users to > send emails as someone else. Note that I could spend time figuring out > how to fix it, but I think this is not worth it since I can fix it during > the merge process (if it got accepted). > > 2. Drop the clone commits from the series > > After Simon's review, we decided to drop the last two patches of the > original series since it was related to cloning output and VKMS does > not support it yet. However, after we finish this series, I can try > to take a look at this feature or maybe propose it as a GSoC/Outreachy > project. > > Most of the changes happened in the second patch. > > 3. Cross-platform improvements > > 4. Add test description and remove some unnecessary code > > Thanks > > Brian Starkey (4): > lib/igt_kms: Add writeback support > kms_writeback: Add initial writeback tests > lib: Add function to hash a framebuffer > kms_writeback: Add writeback-check-output > > lib/igt_fb.c | 63 ++++++ > lib/igt_fb.h | 2 + > lib/igt_kms.c | 52 +++++ > lib/igt_kms.h | 6 + > tests/Makefile.sources | 1 + > tests/kms_writeback.c | 450 +++++++++++++++++++++++++++++++++++++++++ > tests/meson.build | 1 + > 7 files changed, 575 insertions(+) > create mode 100644 tests/kms_writeback.c > > -- > 2.28.0 >
On Fri, Sep 04, 2020 at 12:09:18PM +0100, Liviu Dudau wrote: > On Sun, Aug 30, 2020 at 01:44:06PM -0400, Rodrigo Siqueira wrote: > > Hi, > > Hi, > > Can this series be merged? Thanks for the poke. It's merged now. > Neither me nor Brian managed to get accepted > in the i-g-t committers list, so I cannot push it. Let's fix that. Please apply in gitlab.
On Fri, Sep 04, 2020 at 02:56:05PM +0300, Petri Latvala wrote: > On Fri, Sep 04, 2020 at 12:09:18PM +0100, Liviu Dudau wrote: > > On Sun, Aug 30, 2020 at 01:44:06PM -0400, Rodrigo Siqueira wrote: > > > Hi, > > > > Hi, > > > > Can this series be merged? > > Thanks for the poke. It's merged now. Cheers! > > > Neither me nor Brian managed to get accepted > > in the i-g-t committers list, so I cannot push it. > > Let's fix that. Please apply in gitlab. I've done that now. Thanks! Best regards, Liviu > > > -- > Petri Latvala