| Message ID | 20200904142132.6054-1-lorenzo.pieralisi@arm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: mvebu: Remove useless msi_controller allocation/initialization | expand |
On Fri, Sep 4, 2020 at 8:21 AM Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > The mvebu host controller driver allocates an msi_controller structure > without assigning its methods. It's only allocating a pointer, not an actual msi_controller struct. Otherwise, Reviewed-by: Rob Herring <robh@kernel.org> > > This means that the PCI IRQ MSI layer ignores it and that after all it > should not really be needed. > > Remove it. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > --- > drivers/pci/controller/pci-mvebu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c > index c39978b750ec..eee82838f4ba 100644 > --- a/drivers/pci/controller/pci-mvebu.c > +++ b/drivers/pci/controller/pci-mvebu.c > @@ -12,7 +12,6 @@ > #include <linux/gpio.h> > #include <linux/init.h> > #include <linux/mbus.h> > -#include <linux/msi.h> > #include <linux/slab.h> > #include <linux/platform_device.h> > #include <linux/of_address.h> > @@ -70,7 +69,6 @@ struct mvebu_pcie_port; > struct mvebu_pcie { > struct platform_device *pdev; > struct mvebu_pcie_port *ports; > - struct msi_controller *msi; > struct resource io; > struct resource realio; > struct resource mem; > @@ -1127,7 +1125,6 @@ static int mvebu_pcie_probe(struct platform_device *pdev) > bridge->sysdata = pcie; > bridge->ops = &mvebu_pcie_ops; > bridge->align_resource = mvebu_pcie_align_resource; > - bridge->msi = pcie->msi; > > return mvebu_pci_host_probe(bridge); > } > -- > 2.26.1 >
diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index c39978b750ec..eee82838f4ba 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -12,7 +12,6 @@ #include <linux/gpio.h> #include <linux/init.h> #include <linux/mbus.h> -#include <linux/msi.h> #include <linux/slab.h> #include <linux/platform_device.h> #include <linux/of_address.h> @@ -70,7 +69,6 @@ struct mvebu_pcie_port; struct mvebu_pcie { struct platform_device *pdev; struct mvebu_pcie_port *ports; - struct msi_controller *msi; struct resource io; struct resource realio; struct resource mem; @@ -1127,7 +1125,6 @@ static int mvebu_pcie_probe(struct platform_device *pdev) bridge->sysdata = pcie; bridge->ops = &mvebu_pcie_ops; bridge->align_resource = mvebu_pcie_align_resource; - bridge->msi = pcie->msi; return mvebu_pci_host_probe(bridge); }
The mvebu host controller driver allocates an msi_controller structure without assigning its methods. This means that the PCI IRQ MSI layer ignores it and that after all it should not really be needed. Remove it. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Rob Herring <robh@kernel.org> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- drivers/pci/controller/pci-mvebu.c | 3 --- 1 file changed, 3 deletions(-)