| Message ID | 20200907161141.31034-8-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ARM: dts: s5pv210: Cleanup - dtschema warnings | expand |
Works for me on the Galaxy S. Tested-by: Jonathan Bakker <xc-racer2@live.ca> Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The Power Management Unit (PMU) is a separate device which has little > common with clock controller. Moving it to one level up (from clock > controller child to SoC) allows to remove fake simple-bus compatible and > dtbs_check warnings like: > > clock-controller@e0100000: $nodename:0: > 'clock-controller@e0100000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm/boot/dts/s5pv210.dtsi | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index 5c760a6d7955..46221a5c8ce5 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -92,19 +92,16 @@ > }; > > clocks: clock-controller@e0100000 { > - compatible = "samsung,s5pv210-clock", "simple-bus"; > + compatible = "samsung,s5pv210-clock"; > reg = <0xe0100000 0x10000>; > clock-names = "xxti", "xusbxti"; > clocks = <&xxti>, <&xusbxti>; > #clock-cells = <1>; > - #address-cells = <1>; > - #size-cells = <1>; > - ranges; > + }; > > - pmu_syscon: syscon@e0108000 { > - compatible = "samsung-s5pv210-pmu", "syscon"; > - reg = <0xe0108000 0x8000>; > - }; > + pmu_syscon: syscon@e0108000 { > + compatible = "samsung-s5pv210-pmu", "syscon"; > + reg = <0xe0108000 0x8000>; > }; > > pinctrl0: pinctrl@e0200000 { >
diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 5c760a6d7955..46221a5c8ce5 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -92,19 +92,16 @@ }; clocks: clock-controller@e0100000 { - compatible = "samsung,s5pv210-clock", "simple-bus"; + compatible = "samsung,s5pv210-clock"; reg = <0xe0100000 0x10000>; clock-names = "xxti", "xusbxti"; clocks = <&xxti>, <&xusbxti>; #clock-cells = <1>; - #address-cells = <1>; - #size-cells = <1>; - ranges; + }; - pmu_syscon: syscon@e0108000 { - compatible = "samsung-s5pv210-pmu", "syscon"; - reg = <0xe0108000 0x8000>; - }; + pmu_syscon: syscon@e0108000 { + compatible = "samsung-s5pv210-pmu", "syscon"; + reg = <0xe0108000 0x8000>; }; pinctrl0: pinctrl@e0200000 {
The Power Management Unit (PMU) is a separate device which has little common with clock controller. Moving it to one level up (from clock controller child to SoC) allows to remove fake simple-bus compatible and dtbs_check warnings like: clock-controller@e0100000: $nodename:0: 'clock-controller@e0100000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm/boot/dts/s5pv210.dtsi | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)