| Message ID | 20200907175437.4464-1-clabbe.montjoie@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v3] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset | expand |
On Mon, Sep 07, 2020 at 07:54:37PM +0200, Corentin Labbe wrote: > When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset. > Furthermore, there are no need to use items to list only one compatible > in compatible list. > > Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS") > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> Acked-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
On Tue, Sep 08, 2020 at 08:15:56AM +0200, Maxime Ripard wrote: > On Mon, Sep 07, 2020 at 07:54:37PM +0200, Corentin Labbe wrote: > > When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset. > > Furthermore, there are no need to use items to list only one compatible > > in compatible list. > > > > Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS") > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > Acked-by: Maxime Ripard <mripard@kernel.org> Nevermind, I assumed that there would be crypto patches, but there's none so I ended up taking it through our tree. Maxime
diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml index fc823572bcff..90c6d039b91b 100644 --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml @@ -23,8 +23,7 @@ properties: - items: - const: allwinner,sun7i-a20-crypto - const: allwinner,sun4i-a10-crypto - - items: - - const: allwinner,sun8i-a33-crypto + - const: allwinner,sun8i-a33-crypto reg: maxItems: 1 @@ -59,7 +58,9 @@ if: properties: compatible: contains: - const: allwinner,sun6i-a31-crypto + enum: + - allwinner,sun6i-a31-crypto + - allwinner,sun8i-a33-crypto then: required:
When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset. Furthermore, there are no need to use items to list only one compatible in compatible list. Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS") Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- Change since v2: - fixed enum syntax Change since v1: - use an enum for adding allwinner,sun8i-a33-crypto to "reset list" .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)