mbox series

[v3,0/3] ASoC: Add sdw stream operations to dailink ops.

Message ID 20200904182854.3944-1-yung-chuan.liao@linux.intel.com (mailing list archive)
Headers show
Series ASoC: Add sdw stream operations to dailink ops. | expand

Message

Bard Liao Sept. 4, 2020, 6:28 p.m. UTC
Sdw stream operation APIs can be called once per stream. Move these
operations to dailink ops. The linked series is "soundwire: Remove sdw
stream operations from Intel soundwire dai".

Reviewed-by: Vinod Koul <vkoul@kernel.org>

Changes in v3:
 - s/ASOC/ASoC

Pierre-Louis Bossart (3):
  ASoC: soc-dai: clarify return value for get_sdw_stream()
  ASoC: Intel: sof_sdw: add dailink .trigger callback
  ASoC: Intel: sof_sdw: add dailink .prepare and .hw_free callback

 include/sound/soc-dai.h          |  3 +-
 sound/soc/intel/boards/sof_sdw.c | 81 ++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+), 1 deletion(-)

Comments

Mark Brown Sept. 7, 2020, 6:05 p.m. UTC | #1
On Sat, 5 Sep 2020 02:28:51 +0800, Bard Liao wrote:
> Sdw stream operation APIs can be called once per stream. Move these
> operations to dailink ops. The linked series is "soundwire: Remove sdw
> stream operations from Intel soundwire dai".
> 
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> 
> Changes in v3:
>  - s/ASOC/ASoC
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: soc-dai: clarify return value for get_sdw_stream()
      commit: d20e834e13ce349c9b901b9dd8b7013e255083e8
[2/3] ASoC: Intel: sof_sdw: add dailink .trigger callback
      commit: ae3a3918edf57bde7651964be04d0807cccae8f2
[3/3] ASoC: Intel: sof_sdw: add dailink .prepare and .hw_free callback
      commit: 06998d49bcac8a9df3341db99c5f81ae4ef51c84

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Jaroslav Kysela Sept. 8, 2020, 12:26 p.m. UTC | #2
Dne 04. 09. 20 v 20:28 Bard Liao napsal(a):
> Sdw stream operation APIs can be called once per stream. Move these
> operations to dailink ops. The linked series is "soundwire: Remove sdw
> stream operations from Intel soundwire dai".
> 
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> 
> Changes in v3:
>  - s/ASOC/ASoC
> 
> Pierre-Louis Bossart (3):
>   ASoC: soc-dai: clarify return value for get_sdw_stream()
>   ASoC: Intel: sof_sdw: add dailink .trigger callback
>   ASoC: Intel: sof_sdw: add dailink .prepare and .hw_free callback
> 
>  include/sound/soc-dai.h          |  3 +-
>  sound/soc/intel/boards/sof_sdw.c | 81 ++++++++++++++++++++++++++++++++
>  2 files changed, 83 insertions(+), 1 deletion(-)
> 

This patchset depends on the SoundWire patchset
  "[PATCH v2 0/4] soundwire: Remove sdw stream operations from Intel" and
cannot be used standalone. I believe that one maintainer should accept it or
there should be a co-ordination between Mark and Vinod to push this in sync.
We should really settle, how to accept such changes. I believe that Vinod
should take it with the ack from Mark for this case. Please, don't require to
split changes which depends on each other.

For all above patches (I tested them):

Acked-by: Jaroslav Kysela <perex@perex.cz>
Mark Brown Sept. 8, 2020, 12:30 p.m. UTC | #3
On Tue, Sep 08, 2020 at 02:26:14PM +0200, Jaroslav Kysela wrote:

>   "[PATCH v2 0/4] soundwire: Remove sdw stream operations from Intel" and
> cannot be used standalone. I believe that one maintainer should accept it or
> there should be a co-ordination between Mark and Vinod to push this in sync.
> We should really settle, how to accept such changes. I believe that Vinod
> should take it with the ack from Mark for this case. Please, don't require to
> split changes which depends on each other.

Or just tag the bit from Soundwire that needs to be shared so I can pull
it in which is the more usual way to handle this sort of thing.
Vinod Koul Sept. 9, 2020, 7:49 a.m. UTC | #4
On 08-09-20, 14:26, Jaroslav Kysela wrote:
> Dne 04. 09. 20 v 20:28 Bard Liao napsal(a):
> > Sdw stream operation APIs can be called once per stream. Move these
> > operations to dailink ops. The linked series is "soundwire: Remove sdw
> > stream operations from Intel soundwire dai".
> > 
> > Reviewed-by: Vinod Koul <vkoul@kernel.org>
> > 
> > Changes in v3:
> >  - s/ASOC/ASoC
> > 
> > Pierre-Louis Bossart (3):
> >   ASoC: soc-dai: clarify return value for get_sdw_stream()
> >   ASoC: Intel: sof_sdw: add dailink .trigger callback
> >   ASoC: Intel: sof_sdw: add dailink .prepare and .hw_free callback
> > 
> >  include/sound/soc-dai.h          |  3 +-
> >  sound/soc/intel/boards/sof_sdw.c | 81 ++++++++++++++++++++++++++++++++
> >  2 files changed, 83 insertions(+), 1 deletion(-)
> > 
> 
> This patchset depends on the SoundWire patchset
>   "[PATCH v2 0/4] soundwire: Remove sdw stream operations from Intel" and
> cannot be used standalone. I believe that one maintainer should accept it or
> there should be a co-ordination between Mark and Vinod to push this in sync.
> We should really settle, how to accept such changes. I believe that Vinod
> should take it with the ack from Mark for this case. Please, don't require to
> split changes which depends on each other.

I did ask about dependencies, and IIRC looking at code there were none.
Yes you need both the parts to make it work, but both the trees build
fine and these will go for 5.10, so I think these merged are okay.

> 
> For all above patches (I tested them):
> 
> Acked-by: Jaroslav Kysela <perex@perex.cz>
> 
> -- 
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.