| Message ID | 20200908184918.1085-1-luoyonggang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 9/8/20 1:49 PM, Yonggang Luo wrote: > The following changes since commit 6779038537360e957dbded830f76b08ef5070161: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-09-08' int= > o staging (2020-09-08 17:23:31 +0100) > > are available in the Git repository at: > > http://github.com/lygstate/qemu tags/msys2-patches-pull-request > > for you to fetch changes up to 1892e4360f55ac8cbeeeae0043e0a9dc05c50269: > > rcu: add uninit destructor for rcu (2020-09-09 02:34:59 +0800) > > ---------------------------------------------------------------- > msys2 patch queue 2020-09-09 MAINTAINERS doesn't mention a category for msys2, and this patch series doesn't add one. It is unusual to send a pull request without being a listed maintainer for the code in question. I'm not objecting to you taking on a maintainership role, if we are ready for that, but I also worry that you have so few contributions currently in the main repository that you have not necessarily proven the quality of your work. Maybe it's better to just send this as an ordinary patch series, and let an existing maintainer incorporate it?
On 9/8/20 8:56 PM, Eric Blake wrote: > On 9/8/20 1:49 PM, Yonggang Luo wrote: >> The following changes since commit >> 6779038537360e957dbded830f76b08ef5070161: >> >> Merge remote-tracking branch >> 'remotes/armbru/tags/pull-qapi-2020-09-08' int= >> o staging (2020-09-08 17:23:31 +0100) >> >> are available in the Git repository at: >> >> http://github.com/lygstate/qemu tags/msys2-patches-pull-request >> >> for you to fetch changes up to 1892e4360f55ac8cbeeeae0043e0a9dc05c50269: >> >> rcu: add uninit destructor for rcu (2020-09-09 02:34:59 +0800) >> >> ---------------------------------------------------------------- >> msys2 patch queue 2020-09-09 > > MAINTAINERS doesn't mention a category for msys2, and this patch series > doesn't add one. It is unusual to send a pull request without being a > listed maintainer for the code in question. I'm not objecting to you > taking on a maintainership role, if we are ready for that, but I also > worry that you have so few contributions currently in the main > repository that you have not necessarily proven the quality of your > work. Maybe it's better to just send this as an ordinary patch series, > and let an existing maintainer incorporate it? Beside what Eric said, you sent all your patches altogether, this is already an improvement for reviewers, thanks!
On 08/09/2020 20.56, Eric Blake wrote: > On 9/8/20 1:49 PM, Yonggang Luo wrote: >> The following changes since commit >> 6779038537360e957dbded830f76b08ef5070161: >> >> Merge remote-tracking branch >> 'remotes/armbru/tags/pull-qapi-2020-09-08' int= >> o staging (2020-09-08 17:23:31 +0100) >> >> are available in the Git repository at: >> >> http://github.com/lygstate/qemu tags/msys2-patches-pull-request >> >> for you to fetch changes up to 1892e4360f55ac8cbeeeae0043e0a9dc05c50269: >> >> rcu: add uninit destructor for rcu (2020-09-09 02:34:59 +0800) >> >> ---------------------------------------------------------------- >> msys2 patch queue 2020-09-09 > > MAINTAINERS doesn't mention a category for msys2, and this patch series > doesn't add one. It is unusual to send a pull request without being a > listed maintainer for the code in question. I'm not objecting to you > taking on a maintainership role, if we are ready for that, but I also > worry that you have so few contributions currently in the main > repository that you have not necessarily proven the quality of your > work. Maybe it's better to just send this as an ordinary patch series, > and let an existing maintainer incorporate it? We already have a maintainer for Windows-related patches (see W32, W64 section in maintainers), so I was hoping that Stefan Weil could pick up the msys2 related patches, too. Stefan? Thomas
The following changes since commit 6779038537360e957dbded830f76b08ef5070161: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-09-08' int= o staging (2020-09-08 17:23:31 +0100) are available in the Git repository at: http://github.com/lygstate/qemu tags/msys2-patches-pull-request for you to fetch changes up to 1892e4360f55ac8cbeeeae0043e0a9dc05c50269: rcu: add uninit destructor for rcu (2020-09-09 02:34:59 +0800) ---------------------------------------------------------------- msys2 patch queue 2020-09-09 It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and disa= ble partial test-char tests. And then fixes a number of unit tests failure on msys2/mingw ---------------------------------------------------------------- Yonggang Luo (16): block: Fixes nfs on msys2/mingw ci: fixes msys2 build by upgrading capstone to 4.0.2 configure: Fixes ncursesw detection under msys2/mingw and enable curses curses: Fixes curses compiling errors. tests: disable /char/stdio/* tests in test-char.c on win32 ci: Enable msys2 ci in cirrus tests: Trying fixes test-replication.c on msys2/mingw. block: get file-win32.c handle locking option consistence with file-posix.c osdep: These function are only available on Non-Win32 system. meson: Use -b to ignore CR vs. CR-LF issues on Windows meson: disable crypto tests are empty under win32 meson: remove empty else and duplicated gio deps vmstate: Fixes test-vmstate.c on msys2/mingw cirrus: Building freebsd in a single short logging: Fixes memory leak in test-logging.c rcu: add uninit destructor for rcu .cirrus.yml | 59 ++++++++++++++++------------- block/file-win32.c | 23 ++++++++++- block/nfs.c | 26 ++++++++----- capstone | 2 +- configure | 11 ++---- include/qemu/osdep.h | 2 +- include/qemu/rcu.h | 5 +++ meson.build | 6 --- scripts/ci/windows/msys2-build.sh | 28 ++++++++++++++ scripts/ci/windows/msys2-install.sh | 33 ++++++++++++++++ tests/meson.build | 3 +- tests/qapi-schema/meson.build | 2 +- tests/test-char.c | 4 ++ tests/test-logging.c | 4 +- tests/test-replication.c | 13 +++++-- tests/test-vmstate.c | 2 +- ui/curses.c | 14 +++---- util/rcu.c | 37 +++++++++++++++++- 18 files changed, 205 insertions(+), 69 deletions(-) create mode 100644 scripts/ci/windows/msys2-build.sh create mode 100644 scripts/ci/windows/msys2-install.sh --=20 2.28.0.windows.1