| Message ID | 20200827181842.1000451-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | qspi binding and DTS fixes | expand |
Patch series looks good. Acked-by: Scott Branden <scott.branden@broadcom.com> On 2020-08-27 11:18 a.m., Florian Fainelli wrote: > Hi all, > > This patch series fixes incorrectly defined compatible strings for the > Broadcom QSPI controller which resulted in the strings not being > ordered from most to least compatible. > > We will need to apply some changes to the spi-bcm-qspi.c driver in > the future to assume no revision register exist, and these patches > are a preliminary step towards that goal. > > Florian Fainelli (5): > dt-bindings: spi: Fix spi-bcm-qspi compatible ordering > ARM: dts: bcm: HR2: Fixed QSPI compatible string > ARM: dts: NSP: Fixed QSPI compatible string > ARM: dts: BCM5301X: Fixed QSPI compatible string > arm64: dts: ns2: Fixed QSPI compatible string > > .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++-------- > arch/arm/boot/dts/bcm-hr2.dtsi | 2 +- > arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- > arch/arm/boot/dts/bcm5301x.dtsi | 2 +- > arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +- > 5 files changed, 12 insertions(+), 12 deletions(-) >
Looks good to me. Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> On Thu, Aug 27, 2020 at 3:30 PM Scott Branden <scott.branden@broadcom.com> wrote: > > Patch series looks good. > > Acked-by: Scott Branden <scott.branden@broadcom.com> > > On 2020-08-27 11:18 a.m., Florian Fainelli wrote: > > Hi all, > > > > This patch series fixes incorrectly defined compatible strings for the > > Broadcom QSPI controller which resulted in the strings not being > > ordered from most to least compatible. > > > > We will need to apply some changes to the spi-bcm-qspi.c driver in > > the future to assume no revision register exist, and these patches > > are a preliminary step towards that goal. > > > > Florian Fainelli (5): > > dt-bindings: spi: Fix spi-bcm-qspi compatible ordering > > ARM: dts: bcm: HR2: Fixed QSPI compatible string > > ARM: dts: NSP: Fixed QSPI compatible string > > ARM: dts: BCM5301X: Fixed QSPI compatible string > > arm64: dts: ns2: Fixed QSPI compatible string > > > > .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++-------- > > arch/arm/boot/dts/bcm-hr2.dtsi | 2 +- > > arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- > > arch/arm/boot/dts/bcm5301x.dtsi | 2 +- > > arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +- > > 5 files changed, 12 insertions(+), 12 deletions(-) > > >
On 8/27/2020 11:18 AM, Florian Fainelli wrote: > Hi all, > > This patch series fixes incorrectly defined compatible strings for the > Broadcom QSPI controller which resulted in the strings not being > ordered from most to least compatible. > > We will need to apply some changes to the spi-bcm-qspi.c driver in > the future to assume no revision register exist, and these patches > are a preliminary step towards that goal. Rob, can I get your tag for this patch series so it can be sent out? Thanks! > > Florian Fainelli (5): > dt-bindings: spi: Fix spi-bcm-qspi compatible ordering > ARM: dts: bcm: HR2: Fixed QSPI compatible string > ARM: dts: NSP: Fixed QSPI compatible string > ARM: dts: BCM5301X: Fixed QSPI compatible string > arm64: dts: ns2: Fixed QSPI compatible string > > .../bindings/spi/brcm,spi-bcm-qspi.txt | 16 ++++++++-------- > arch/arm/boot/dts/bcm-hr2.dtsi | 2 +- > arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- > arch/arm/boot/dts/bcm5301x.dtsi | 2 +- > arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 2 +- > 5 files changed, 12 insertions(+), 12 deletions(-) >
On 8/27/2020 11:18 AM, Florian Fainelli wrote: > Hi all, > > This patch series fixes incorrectly defined compatible strings for the > Broadcom QSPI controller which resulted in the strings not being > ordered from most to least compatible. > > We will need to apply some changes to the spi-bcm-qspi.c driver in > the future to assume no revision register exist, and these patches > are a preliminary step towards that goal. Series applied to devicetree/fixes, sending the PR shortly.