| Message ID | 20200910075433.26718-3-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: ti: j721e-evm: Support for j7200 variant | expand |
Hi Peter,
I love your patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.9-rc4 next-20200909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/ti/j721e-evm.c:532:3: warning: this decimal constant is unsigned only in ISO C90
532 | [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */
| ^
# https://github.com/0day-ci/linux/commit/63afa4709f3914bb58dd727c1119c447a23ce150
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534
git checkout 63afa4709f3914bb58dd727c1119c447a23ce150
vim +532 sound/soc/ti/j721e-evm.c
527
528 static const struct j721e_audio_match_data j7200_cpb_data = {
529 .board_type = J721E_BOARD_CPB,
530 .num_links = 2, /* CPB pcm3168a */
531 .pll_rates = {
> 532 [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */
533 },
534 };
535
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi, On 10/09/2020 12.54, kernel test robot wrote: > Hi Peter, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on asoc/for-next] > [also build test WARNING on v5.9-rc4 next-20200909] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534 > base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > config: m68k-allmodconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > >>> sound/soc/ti/j721e-evm.c:532:3: warning: this decimal constant is unsigned only in ISO C90 > 532 | [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */ > | ^ > > # https://github.com/0day-ci/linux/commit/63afa4709f3914bb58dd727c1119c447a23ce150 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534 > git checkout 63afa4709f3914bb58dd727c1119c447a23ce150 > vim +532 sound/soc/ti/j721e-evm.c > > 527 > 528 static const struct j721e_audio_match_data j7200_cpb_data = { > 529 .board_type = J721E_BOARD_CPB, > 530 .num_links = 2, /* CPB pcm3168a */ > 531 .pll_rates = { > > 532 [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */ struct j721e_audio_match_data { enum j721e_board_type board_type; int num_links; unsigned int pll_rates[2]; }; pll_rates _is_ unsigned int. > 533 }, > 534 }; > 535 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 10/09/2020 14.48, Peter Ujfalusi wrote: > Hi, > > On 10/09/2020 12.54, kernel test robot wrote: >> Hi Peter, >> >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on asoc/for-next] >> [also build test WARNING on v5.9-rc4 next-20200909] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next >> config: m68k-allmodconfig (attached as .config) >> compiler: m68k-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All warnings (new ones prefixed by >>): >> >>>> sound/soc/ti/j721e-evm.c:532:3: warning: this decimal constant is unsigned only in ISO C90 >> 532 | [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */ >> | ^ >> >> # https://github.com/0day-ci/linux/commit/63afa4709f3914bb58dd727c1119c447a23ce150 >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Peter-Ujfalusi/ASoC-ti-j721e-evm-Support-for-j7200-variant/20200910-155534 >> git checkout 63afa4709f3914bb58dd727c1119c447a23ce150 >> vim +532 sound/soc/ti/j721e-evm.c >> >> 527 >> 528 static const struct j721e_audio_match_data j7200_cpb_data = { >> 529 .board_type = J721E_BOARD_CPB, >> 530 .num_links = 2, /* CPB pcm3168a */ >> 531 .pll_rates = { >> > 532 [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */ Suffixing with 'u' silences the warning for C90, I'll send v2 > > struct j721e_audio_match_data { > enum j721e_board_type board_type; > int num_links; > unsigned int pll_rates[2]; > }; > > pll_rates _is_ unsigned int. > >> 533 }, >> 534 }; >> 535 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >> > > - Péter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c index cb074af47a7d..f66674fd5f64 100644 --- a/sound/soc/ti/j721e-evm.c +++ b/sound/soc/ti/j721e-evm.c @@ -525,6 +525,14 @@ static const struct j721e_audio_match_data j721e_cpb_ivi_data = { }, }; +static const struct j721e_audio_match_data j7200_cpb_data = { + .board_type = J721E_BOARD_CPB, + .num_links = 2, /* CPB pcm3168a */ + .pll_rates = { + [J721E_CLK_PARENT_48000] = 2359296000, /* PLL4 */ + }, +}; + static const struct of_device_id j721e_audio_of_match[] = { { .compatible = "ti,j721e-cpb-audio", @@ -532,6 +540,9 @@ static const struct of_device_id j721e_audio_of_match[] = { }, { .compatible = "ti,j721e-cpb-ivi-audio", .data = &j721e_cpb_ivi_data, + }, { + .compatible = "ti,j7200-cpb-audio", + .data = &j7200_cpb_data, }, { }, };
When j7200 SOM is attached to the CPB we only have parent clock for 48KHz family and the rate of the parent clock is 2359296000Hz. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- sound/soc/ti/j721e-evm.c | 11 +++++++++++ 1 file changed, 11 insertions(+)