| Message ID | 20200909134234.31204-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | [-next] PCI: dwc: unexport dw_pcie_link_set_max_speed | expand |
On Wed, Sep 9, 2020 at 7:42 AM YueHaibing <yuehaibing@huawei.com> wrote: > > This function has been made static, which causes warning: > > WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL > > Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/pci/controller/dwc/pcie-designware.c | 1 - > 1 file changed, 1 deletion(-) Thanks for fixing. Acked-by: Rob Herring <robh@kernel.org>
On Wed, Sep 09, 2020 at 09:42:34PM +0800, YueHaibing wrote: > This function has been made static, which causes warning: > > WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL > > Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting") This commit is still on Lorenzo's pci/dwc branch, so he should be able to squash this fix in. > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/pci/controller/dwc/pcie-designware.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 4d105efb5722..3c3a4d1dbc0b 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -508,7 +508,6 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen) > dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, cap | link_speed); > > } > -EXPORT_SYMBOL_GPL(dw_pcie_link_set_max_speed); > > static u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci) > { > -- > 2.17.1 > >
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index 4d105efb5722..3c3a4d1dbc0b 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -508,7 +508,6 @@ static void dw_pcie_link_set_max_speed(struct dw_pcie *pci, u32 link_gen) dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, cap | link_speed); } -EXPORT_SYMBOL_GPL(dw_pcie_link_set_max_speed); static u8 dw_pcie_iatu_unroll_enabled(struct dw_pcie *pci) {
This function has been made static, which causes warning: WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL Fixes: 3af45d34d30c ("PCI: dwc: Centralize link gen setting") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/pci/controller/dwc/pcie-designware.c | 1 - 1 file changed, 1 deletion(-)