| Message ID | 20200910175733.11046-13-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | ARM: dts: / gpio: Add dtschema for NXP PCA953x and correct dts | expand |
On Thu, 10 Sep 2020 at 17:59, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > dtschema for pca95xx expects GPIO hogs to end with 'hog' prefix. This is a bit ugly. Do we have to go down this path? > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 2 +- > arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 16 ++++++++-------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > index 1fa233d2da26..0aa437486a0d 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > @@ -560,7 +560,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus0 { > + smbus0-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts > index cb85168f6761..577c211c469e 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts > @@ -827,7 +827,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus0 { > + smbus0-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > @@ -852,7 +852,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus1 { > + smbus1-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > @@ -900,7 +900,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus2 { > + smbus2-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > @@ -925,7 +925,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus3 { > + smbus3-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > @@ -992,7 +992,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus4 { > + smbus4-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > @@ -1017,7 +1017,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus5 { > + smbus5-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > @@ -1065,7 +1065,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus6 { > + smbus6-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > @@ -1090,7 +1090,7 @@ > gpio-controller; > #gpio-cells = <2>; > > - smbus7 { > + smbus7-hog { > gpio-hog; > gpios = <4 GPIO_ACTIVE_HIGH>; > output-high; > -- > 2.17.1 >
On Fri, 11 Sep 2020 at 02:58, Joel Stanley <joel@jms.id.au> wrote: > > On Thu, 10 Sep 2020 at 17:59, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > dtschema for pca95xx expects GPIO hogs to end with 'hog' prefix. > > This is a bit ugly. Do we have to go down this path? No, but please comment on schema (1/15 in this series). Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts index 1fa233d2da26..0aa437486a0d 100644 --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts @@ -560,7 +560,7 @@ gpio-controller; #gpio-cells = <2>; - smbus0 { + smbus0-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts index cb85168f6761..577c211c469e 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts @@ -827,7 +827,7 @@ gpio-controller; #gpio-cells = <2>; - smbus0 { + smbus0-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; @@ -852,7 +852,7 @@ gpio-controller; #gpio-cells = <2>; - smbus1 { + smbus1-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; @@ -900,7 +900,7 @@ gpio-controller; #gpio-cells = <2>; - smbus2 { + smbus2-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; @@ -925,7 +925,7 @@ gpio-controller; #gpio-cells = <2>; - smbus3 { + smbus3-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; @@ -992,7 +992,7 @@ gpio-controller; #gpio-cells = <2>; - smbus4 { + smbus4-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; @@ -1017,7 +1017,7 @@ gpio-controller; #gpio-cells = <2>; - smbus5 { + smbus5-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; @@ -1065,7 +1065,7 @@ gpio-controller; #gpio-cells = <2>; - smbus6 { + smbus6-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high; @@ -1090,7 +1090,7 @@ gpio-controller; #gpio-cells = <2>; - smbus7 { + smbus7-hog { gpio-hog; gpios = <4 GPIO_ACTIVE_HIGH>; output-high;
dtschema for pca95xx expects GPIO hogs to end with 'hog' prefix. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 2 +- arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-)