| Message ID | 20200914091846.55204-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5d8ff95a52c36740bf4e61202d08549e7a9caf20 |
| Headers | show |
| Series | [v3] pinctrl: qcom: sm8250: correct sdc2_clk | expand |
On Mon, Sep 14, 2020 at 12:18:46PM +0300, Dmitry Baryshkov wrote: > Correct sdc2_clk pin definition (register offset is wrong, verified by > the msm-4.19 driver). > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a > --- > drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c > index a660f1274b66..826df0d637ea 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c > @@ -1308,7 +1308,7 @@ static const struct msm_pingroup sm8250_groups[] = { > [178] = PINGROUP(178, WEST, _, _, _, _, _, _, _, _, _), > [179] = PINGROUP(179, WEST, _, _, _, _, _, _, _, _, _), > [180] = UFS_RESET(ufs_reset, 0xb8000), > - [181] = SDC_PINGROUP(sdc2_clk, 0x7000, 14, 6), > + [181] = SDC_PINGROUP(sdc2_clk, 0xb7000, 14, 6), > [182] = SDC_PINGROUP(sdc2_cmd, 0xb7000, 11, 3), > [183] = SDC_PINGROUP(sdc2_data, 0xb7000, 9, 0), > }; > -- > 2.28.0 >
On Mon 14 Sep 04:18 CDT 2020, Dmitry Baryshkov wrote: > Correct sdc2_clk pin definition (register offset is wrong, verified by > the msm-4.19 driver). > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c > index a660f1274b66..826df0d637ea 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c > @@ -1308,7 +1308,7 @@ static const struct msm_pingroup sm8250_groups[] = { > [178] = PINGROUP(178, WEST, _, _, _, _, _, _, _, _, _), > [179] = PINGROUP(179, WEST, _, _, _, _, _, _, _, _, _), > [180] = UFS_RESET(ufs_reset, 0xb8000), > - [181] = SDC_PINGROUP(sdc2_clk, 0x7000, 14, 6), > + [181] = SDC_PINGROUP(sdc2_clk, 0xb7000, 14, 6), > [182] = SDC_PINGROUP(sdc2_cmd, 0xb7000, 11, 3), > [183] = SDC_PINGROUP(sdc2_data, 0xb7000, 9, 0), > }; > -- > 2.28.0 >
On Mon, Sep 14, 2020 at 11:18 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > Correct sdc2_clk pin definition (register offset is wrong, verified by > the msm-4.19 driver). > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a Patch applied for fixes! Thanks for sorting this out. Yours, Linus Walleij
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c b/drivers/pinctrl/qcom/pinctrl-sm8250.c index a660f1274b66..826df0d637ea 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm8250.c +++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c @@ -1308,7 +1308,7 @@ static const struct msm_pingroup sm8250_groups[] = { [178] = PINGROUP(178, WEST, _, _, _, _, _, _, _, _, _), [179] = PINGROUP(179, WEST, _, _, _, _, _, _, _, _, _), [180] = UFS_RESET(ufs_reset, 0xb8000), - [181] = SDC_PINGROUP(sdc2_clk, 0x7000, 14, 6), + [181] = SDC_PINGROUP(sdc2_clk, 0xb7000, 14, 6), [182] = SDC_PINGROUP(sdc2_cmd, 0xb7000, 11, 3), [183] = SDC_PINGROUP(sdc2_data, 0xb7000, 9, 0), };
Correct sdc2_clk pin definition (register offset is wrong, verified by the msm-4.19 driver). Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Fixes: 4e3ec9e407ad5058003309072b37111f7b8c900a --- drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)