| Message ID | 1600091917-7464-4-git-send-email-skakit@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add wakeup support over UART RX | expand |
On Mon, Sep 14, 2020 at 07:28:36PM +0530, satya priya wrote: > Add the necessary pinctrl, interrupt property and a suitable sleep config > to support Bluetooth wakeup feature. > > GPIO mode is configured in sleep state to drive the RTS/RFR line low. > If QUP function is selected in sleep state, UART RTS/RFR is pulled high > during suspend and BT SoC not able to send wakeup bytes. > > Signed-off-by: satya priya <skakit@codeaurora.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org>
Hi, On Mon, Sep 14, 2020 at 6:59 AM satya priya <skakit@codeaurora.org> wrote: > > Add the necessary pinctrl, interrupt property and a suitable sleep config > to support Bluetooth wakeup feature. > > GPIO mode is configured in sleep state to drive the RTS/RFR line low. > If QUP function is selected in sleep state, UART RTS/RFR is pulled high > during suspend and BT SoC not able to send wakeup bytes. > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V5: > - Newly added in V5. This patch adds wakeup support for trogdor board files. > > Changes in V6: > - As per Doug's comment deleted interrupts property and sorted the qup sleep > state before trackpad. > - As per Bjorn's comment canged the commit text, rationale for RTS, TX, RX. > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 54 ++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index a6b9beb..6629df9 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -794,6 +794,13 @@ ap_spi_fp: &spi10 { &uart3 { status = "okay"; + /delete-property/interrupts; + interrupts-extended = <&intc GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>, + <&tlmm 41 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-names = "default", "sleep"; + pinctrl-1 = <&qup_uart3_sleep>; + bluetooth: bluetooth { compatible = "qcom,wcn3991-bt"; vddio-supply = <&pp1800_l10a>; @@ -1307,6 +1314,53 @@ ap_spi_fp: &spi10 { }; }; + qup_uart3_sleep: qup-uart3-sleep { + pinmux { + pins = "gpio38", "gpio39", + "gpio40", "gpio41"; + function = "gpio"; + }; + + pinconf-cts { + /* + * Configure a pull-down on CTS to match the pull of + * the Bluetooth module. + */ + pins = "gpio38"; + bias-pull-down; + }; + + pinconf-rts { + /* + * Configure pull-down on RTS. As RTS is active low + * signal, pull it low to indicate the BT SoC that it + * can wakeup the system anytime from suspend state by + * pulling RX low (by sending wakeup bytes). + */ + pins = "gpio39"; + bias-pull-down; + }; + + pinconf-tx { + /* + * Configure pull-up on TX when it isn't actively driven + * to prevent BT SoC from receiving garbage during sleep. + */ + pins = "gpio40"; + bias-pull-up; + }; + + pinconf-rx { + /* + * Configure a pull-up on RX. This is needed to avoid + * garbage data when the TX pin of the Bluetooth module + * is floating which may cause spurious wakeups. + */ + pins = "gpio41"; + bias-pull-up; + }; + }; + trackpad_int_1v8_odl: trackpad-int-1v8-odl { pinmux { pins = "gpio58";
Add the necessary pinctrl, interrupt property and a suitable sleep config to support Bluetooth wakeup feature. GPIO mode is configured in sleep state to drive the RTS/RFR line low. If QUP function is selected in sleep state, UART RTS/RFR is pulled high during suspend and BT SoC not able to send wakeup bytes. Signed-off-by: satya priya <skakit@codeaurora.org> --- Changes in V5: - Newly added in V5. This patch adds wakeup support for trogdor board files. Changes in V6: - As per Doug's comment deleted interrupts property and sorted the qup sleep state before trackpad. - As per Bjorn's comment canged the commit text, rationale for RTS, TX, RX. arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 54 ++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)