mbox series

[net-next,0/3] net: stmmac: Add ethtool support for get|set channels

Message ID 20200915012840.31841-1-vee.khee.wong@intel.com (mailing list archive)
Headers show
Series net: stmmac: Add ethtool support for get|set channels | expand

Message

Wong, Vee Khee Sept. 15, 2020, 1:28 a.m. UTC 
This patch set is to add support for user to get or set Tx/Rx channel
via ethtool. There are two patches that fixes bug introduced on upstream
in order to have the feature work.

Tested on Intel Tigerlake Platform.

Aashish Verma (1):
  net: stmmac: Fix incorrect location to set real_num_rx|tx_queues

Ong Boon Leong (2):
  net: stmmac: add ethtool support for get/set channels
  net: stmmac: use netif_tx_start|stop_all_queues() function

 drivers/net/ethernet/stmicro/stmmac/stmmac.h  |   1 +
 .../ethernet/stmicro/stmmac/stmmac_ethtool.c  |  26 ++++
 .../net/ethernet/stmicro/stmmac/stmmac_main.c | 135 +++++++++---------
 3 files changed, 98 insertions(+), 64 deletions(-)

Comments

David Miller Sept. 15, 2020, 10:43 p.m. UTC | #1 
From: Wong Vee Khee <vee.khee.wong@intel.com>
Date: Tue, 15 Sep 2020 09:28:37 +0800

> This patch set is to add support for user to get or set Tx/Rx channel
> via ethtool. There are two patches that fixes bug introduced on upstream
> in order to have the feature work.
> 
> Tested on Intel Tigerlake Platform.

Series applied, thank you.
Florian Fainelli Sept. 15, 2020, 10:54 p.m. UTC | #2 
On 9/15/2020 3:43 PM, David Miller wrote:
> From: Wong Vee Khee <vee.khee.wong@intel.com>
> Date: Tue, 15 Sep 2020 09:28:37 +0800
> 
>> This patch set is to add support for user to get or set Tx/Rx channel
>> via ethtool. There are two patches that fixes bug introduced on upstream
>> in order to have the feature work.
>>
>> Tested on Intel Tigerlake Platform.
> 
> Series applied, thank you.

patch #2 does not have a proper Fixes: tag format, it should be:

Fixes: cafebabed00d ("some super subject")
Wong, Vee Khee Sept. 15, 2020, 11:59 p.m. UTC | #3 
My bad...

Hi David Miller,

Can you help with the commit message fix or do you want to to send a new patch with the fix since the patches are applied on net-next?

Regards,
Vee Khee

> -----Original Message-----
> From: Florian Fainelli <f.fainelli@gmail.com>
> Sent: Wednesday, September 16, 2020 6:54 AM
> To: David Miller <davem@davemloft.net>; Wong, Vee Khee
> <vee.khee.wong@intel.com>
> Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com;
> joabreu@synopsys.com; mcoquelin.stm32@gmail.com; kuba@kernel.org;
> Joao.Pinto@synopsys.com; arnd@arndb.de; linux@armlinux.org.uk;
> netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Ong,
> Boon Leong <boon.leong.ong@intel.com>; Voon, Weifeng
> <weifeng.voon@intel.com>; Vijaya Balan, Sadhishkhanna
> <sadhishkhanna.vijaya.balan@intel.com>; Seow, Chen Yong
> <chen.yong.seow@intel.com>
> Subject: Re: [PATCH net-next 0/3] net: stmmac: Add ethtool support for
> get|set channels
> 
> 
> 
> On 9/15/2020 3:43 PM, David Miller wrote:
> > From: Wong Vee Khee <vee.khee.wong@intel.com>
> > Date: Tue, 15 Sep 2020 09:28:37 +0800
> >
> >> This patch set is to add support for user to get or set Tx/Rx channel
> >> via ethtool. There are two patches that fixes bug introduced on
> >> upstream in order to have the feature work.
> >>
> >> Tested on Intel Tigerlake Platform.
> >
> > Series applied, thank you.
> 
> patch #2 does not have a proper Fixes: tag format, it should be:
> 
> Fixes: cafebabed00d ("some super subject")
> --
> Florian
Florian Fainelli Sept. 16, 2020, 12:02 a.m. UTC | #4 
On 9/15/2020 4:59 PM, Wong, Vee Khee wrote:
> My bad...
> 
> Hi David Miller,

(please don't top post)

> 
> Can you help with the commit message fix or do you want to to send a new patch with the fix since the patches are applied on net-next?

It has already been applied, so this is too late, just telling you so 
you can avoid it next time. And it should be part of David's CI while 
applying patching, too.