diff mbox series

device-dax: make dev_dax_kmem_probe() static

Message ID 20200912033901.143382-1-yanaijie@huawei.com (mailing list archive)
State New, archived
Headers show
Series device-dax: make dev_dax_kmem_probe() static | expand

Commit Message

Jason Yan Sept. 12, 2020, 3:39 a.m. UTC
This eliminates the following sparse warning:

drivers/dax/kmem.c:38:5: warning: symbol 'dev_dax_kmem_probe' was not
declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/dax/kmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ira Weiny Sept. 17, 2020, 5:20 p.m. UTC | #1
On Sat, Sep 12, 2020 at 11:39:01AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
> 
> drivers/dax/kmem.c:38:5: warning: symbol 'dev_dax_kmem_probe' was not
> declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  drivers/dax/kmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c
> index 7dcb2902e9b1..e79afbadd4e0 100644
> --- a/drivers/dax/kmem.c
> +++ b/drivers/dax/kmem.c
> @@ -35,7 +35,7 @@ static int dax_kmem_range(struct dev_dax *dev_dax, int i, struct range *r)
>  	return 0;
>  }
>  
> -int dev_dax_kmem_probe(struct dev_dax *dev_dax)
> +static int dev_dax_kmem_probe(struct dev_dax *dev_dax)
>  {
>  	int numa_node = dev_dax->target_node;
>  	struct device *dev = &dev_dax->dev;
> -- 
> 2.25.4
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
diff mbox series

Patch

diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c
index 7dcb2902e9b1..e79afbadd4e0 100644
--- a/drivers/dax/kmem.c
+++ b/drivers/dax/kmem.c
@@ -35,7 +35,7 @@  static int dax_kmem_range(struct dev_dax *dev_dax, int i, struct range *r)
 	return 0;
 }
 
-int dev_dax_kmem_probe(struct dev_dax *dev_dax)
+static int dev_dax_kmem_probe(struct dev_dax *dev_dax)
 {
 	int numa_node = dev_dax->target_node;
 	struct device *dev = &dev_dax->dev;