mbox series

[v4,0/3] soundwire: qcom: fix IP version v1.5.1 support

Message ID 20200917120138.11313-1-srinivas.kandagatla@linaro.org (mailing list archive)
Headers show
Series soundwire: qcom: fix IP version v1.5.1 support | expand

Message

Srinivas Kandagatla Sept. 17, 2020, 12:01 p.m. UTC
While testing Qualcomm soundwire controller version 1.5.1, found two issue,
Firstly the frame shape information configured vs the bus parameters
are out of sync. secondly some ports on this ip version require
block packing mode support.

With this patchset I was able to test 2 WSA speakers!

Also I found a regression due to move to REG_FIELD, which patch 1 fixes it!

thanks,
srini


Change since v3:
- use u32p_replace_bits instead of u32_replace_bits

Srinivas Kandagatla (3):
  soundwire: qcom: clear BIT FIELDs before value set.
  soundwire: qcom: add support to block packing mode
  soundwire: qcom: get max rows and cols info from compatible

 drivers/soundwire/qcom.c | 70 +++++++++++++++++++++++++++++-----------
 1 file changed, 51 insertions(+), 19 deletions(-)

Comments

Vinod Koul Sept. 18, 2020, 12:02 p.m. UTC | #1
On 17-09-20, 13:01, Srinivas Kandagatla wrote:
> While testing Qualcomm soundwire controller version 1.5.1, found two issue,
> Firstly the frame shape information configured vs the bus parameters
> are out of sync. secondly some ports on this ip version require
> block packing mode support.
> 
> With this patchset I was able to test 2 WSA speakers!
> 
> Also I found a regression due to move to REG_FIELD, which patch 1 fixes it!

Applied all, thanks