| Message ID | 20200912033741.142415-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: isci: make isci_host_attrs static | expand |
Jason, > This eliminates the following sparse warning: > > drivers/scsi/isci/init.c:145:25: warning: symbol 'isci_host_attrs' was > not declared. Should it be static? Applied to 5.10/scsi-staging, thanks!
On Sat, 12 Sep 2020 11:37:41 +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/scsi/isci/init.c:145:25: warning: symbol 'isci_host_attrs' was > not declared. Should it be static? Applied to 5.10/scsi-queue, thanks! [1/1] scsi: isci: Make isci_host_attrs static https://git.kernel.org/mkp/scsi/c/7867c549d574
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c index 085e285f427d..93bc9019667f 100644 --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -142,7 +142,7 @@ static ssize_t isci_show_id(struct device *dev, struct device_attribute *attr, c static DEVICE_ATTR(isci_id, S_IRUGO, isci_show_id, NULL); -struct device_attribute *isci_host_attrs[] = { +static struct device_attribute *isci_host_attrs[] = { &dev_attr_isci_id, NULL };
This eliminates the following sparse warning: drivers/scsi/isci/init.c:145:25: warning: symbol 'isci_host_attrs' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/scsi/isci/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)