| Message ID | 20200923072740.20772-1-mirucam@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Finish converting git bisect to C part 2 subset 1 | expand |
Hi Miriam, On Wed, 23 Sep 2020, Miriam Rubio wrote: > General changes > --------------- > > * Rebased on 385c171a01, (Fifteenth batch, 2020-09-18) to update command > help messages. > > > Specific changes > ---------------- > > > [4/6] bisect--helper: reimplement `bisect_autostart` shell function in C > > * Amend commit message. > * Change to `return -1` when we cannot autostart. > * Add `|| exit` to bisect-autostart call in shell script. I think the `bisect_next` function needs the same treatment. Other than that, this iteration is ready to go from my side. Thank you, Dscho
Miriam Rubio <mirucam@gmail.com> writes: > These patches correspond to a second part of patch series > of Outreachy project "Finish converting `git bisect` from shell to C" > started by Pranit Bauva and Tanushree Tumane > (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and > continued by me. > > This patch series version is composed by the first six patches of the > previous version due to a bug discovered during the test stage, that > affects the rest of the patches and that needs to be fixed before > sending them. Thanks for being careful. > * Rebased on 385c171a01, (Fifteenth batch, 2020-09-18) to update command > help messages. Personally I find this rebase unwarranted. What ef4d9f8a (bisect: swap command-line options in documentation, 2020-08-28) on the 'master' did does not overlap with this series in any meaningful way. Since it is also trivial to adjust these patches back on e9b77c84 (Tenth batch, 2020-08-24) on which the previous round was based, I won't complain ;-) > [4/6] bisect--helper: reimplement `bisect_autostart` shell function in C > > * Amend commit message. > * Change to `return -1` when we cannot autostart. > * Add `|| exit` to bisect-autostart call in shell script. Sounds good. > [6/6] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell > functions in C > > * Amend commit message. > * Amend new modes order in cmdmode enum. Meaning that the two new ones can just be at the end and there wasn't a reason for them to come before autostart? OK. > * Add `|| exit` to bisect-auto-next call in shell script. OK. Thanks.
These patches correspond to a second part of patch series of Outreachy project "Finish converting `git bisect` from shell to C" started by Pranit Bauva and Tanushree Tumane (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and continued by me. This patch series version is composed by the first six patches of the previous version due to a bug discovered during the test stage, that affects the rest of the patches and that needs to be fixed before sending them. These patch series emails were generated from: https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v8-subset1. I would like to thank Johannes Schindelin for reviewing this patch series and to Christian Couder for his advice and help. General changes --------------- * Rebased on 385c171a01, (Fifteenth batch, 2020-09-18) to update command help messages. Specific changes ---------------- [4/6] bisect--helper: reimplement `bisect_autostart` shell function in C * Amend commit message. * Change to `return -1` when we cannot autostart. * Add `|| exit` to bisect-autostart call in shell script. --- [6/6] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C * Amend commit message. * Amend new modes order in cmdmode enum. * Add `|| exit` to bisect-auto-next call in shell script. --- Miriam Rubio (4): bisect--helper: BUG() in cmd_*() on invalid subcommand bisect--helper: use '-res' in 'cmd_bisect__helper' return bisect--helper: introduce new `write_in_file()` function bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()' Pranit Bauva (2): bisect--helper: reimplement `bisect_autostart` shell function in C bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C bisect.c | 13 +- builtin/bisect--helper.c | 269 +++++++++++++++++++++++++++++++++++++-- git-bisect.sh | 70 +--------- 3 files changed, 274 insertions(+), 78 deletions(-)