| Message ID | 20200905143230.195049-1-nchatrad@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RFC: hwmon: few improvements to amd_energy driver | expand |
[AMD Public Use]
Hi Guenter,
-----Original Message-----
From: Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@amd.com>
Sent: Saturday, September 5, 2020 8:02 PM
To: linux-hwmon@vger.kernel.org
Cc: linux@roeck-us.net; Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@amd.com>
Subject: [PATCH 0/6] RFC: hwmon: few improvements to amd_energy driver
Hi Guenter,
Would like to know your feedback on the following features for the amd_energy driver.
1) Sysfs entry for dumping energy counters of all the cores
- On latest CPUs there can be as many as 128 cores.
An ABI for dumping all 128 counters using seq_printf()
to a debugfs/sysfs file would save a lot of cycles.
2) Enable/Disable the accumulation, Disabled by default
- The accumulator thread may introduce some noise.
Providing a knob to enable/disable (start/stop) the
accumulation in software.
3) Accumulator Interval change based on reported resolution
- Frequency of the accumulator thread can be set during
the probe based on fine grain (1.625 micro J) or course
grain (0.125 milli J) resolutions.
[naveenk:] I will submit the v2 dropping #1 and #2 for now.
Akshay Gupta (1):
hwmon: amd_energy: Move label out of accumulation structure
Naveen Krishna Chatradhi (5):
hwmon: amd_energy: optimize accumulation interval
hwmon: amd_energy: Improve the accumulation logic
hwmon: amd_energy: let user enable/disable the sw accumulation
hwmon: amd_energy: dump energy counters via debugfs
hwmon: (amd_energy) Update driver documentation
Documentation/hwmon/amd_energy.rst | 19 ++
drivers/hwmon/amd_energy.c | 351 +++++++++++++++++++++--------
2 files changed, 273 insertions(+), 97 deletions(-)
--
2.26.2
Hi Guenter, Would like to know your feedback on the following features for the amd_energy driver. 1) Sysfs entry for dumping energy counters of all the cores - On latest CPUs there can be as many as 128 cores. An ABI for dumping all 128 counters using seq_printf() to a debugfs/sysfs file would save a lot of cycles. 2) Enable/Disable the accumulation, Disabled by default - The accumulator thread may introduce some noise. Providing a knob to enable/disable (start/stop) the accumulation in software. 3) Accumulator Interval change based on reported resolution - Frequency of the accumulator thread can be set during the probe based on fine grain (1.625 micro J) or course grain (0.125 milli J) resolutions. Akshay Gupta (1): hwmon: amd_energy: Move label out of accumulation structure Naveen Krishna Chatradhi (5): hwmon: amd_energy: optimize accumulation interval hwmon: amd_energy: Improve the accumulation logic hwmon: amd_energy: let user enable/disable the sw accumulation hwmon: amd_energy: dump energy counters via debugfs hwmon: (amd_energy) Update driver documentation Documentation/hwmon/amd_energy.rst | 19 ++ drivers/hwmon/amd_energy.c | 351 +++++++++++++++++++++-------- 2 files changed, 273 insertions(+), 97 deletions(-)