| Message ID | 20200925033017.1790973-8-art@khadas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dts updates and fixes for Khadas VIM1 VIM2 VIM3 VIML boards | expand |
Hi Artem, On Fri, Sep 25, 2020 at 5:31 AM Artem Lapkin <email2tema@gmail.com> wrote: > > enable RTC for VIM1 meson-gxl-s905x-khadas-vim I think the commit message should always explain *why* the change is necessary (what problem does it solve?) for trivial changes the diff itself explains "what" is being changed [...] > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts > index 8bcdffdf55d..354f21d4171 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts > @@ -98,7 +98,7 @@ &i2c_B { > > rtc: rtc@51 { > /* has to be enabled manually when a battery is connected: */ why do we need to keep this comment? same feedback applies to patch 8 Best regards, Martin
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts index 8bcdffdf55d..354f21d4171 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts @@ -98,7 +98,7 @@ &i2c_B { rtc: rtc@51 { /* has to be enabled manually when a battery is connected: */ - status = "disabled"; + status = "okay"; compatible = "haoyu,hym8563"; reg = <0x51>; #clock-cells = <0>;
enable RTC for VIM1 meson-gxl-s905x-khadas-vim Signed-off-by: Artem Lapkin <art@khadas.com> --- arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)