| Message ID | 20200929125949.69934-1-alexandru.ardelean@analog.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: remove iio_buffer_set_attrs() and assign buffer attrs during alloc | expand |
On Tue, Sep 29, 2020 at 3:55 PM Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > > This is a v2 & v3 for [1]: > https://lore.kernel.org/linux-iio/20200925083743.46469-1-alexandru.ardelean@analog.com/ > > It also includes a at91-sama5d2_adc cleanup patch in this series: > https://lore.kernel.org/linux-iio/20200924102902.136169-1-alexandru.ardelean@analog.com/ > This patch is required, in order to make the removal of > iio_buffer_set_attrs() a bit cleaner in the at91-sama5d2_adc driver. > > Following the discussion from [1], this patchset implements the > following: Makes sense to me, FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenjko> > > Changelog v2 -> v3: > * in patch 'iio: buffer: dmaengine: unwrap the use of iio_buffer_set_attrs()' > - minor stylistic change; > > Changelog v1 -> v2: > * rename '{devm_}iio_triggered_buffer_setup()' -> > '{devm_}iio_triggered_buffer_setup_ext()' > - wrap with macros the new ext functions to preserve backwards > compatibility > - add a new parameter to the ext functions, which are the > buffer->attrs > * split into separate patches the removal [from each driver] of > iio_buffer_set_attrs() and the switch to a > {devm_}iio_triggered_buffer_setup_ext variant > * add patch to remove iio_buffer_set_attrs() from DMAEngine IIO buffer > * remove the iio_buffer_set_attrs() helper in a final/separate patch > * add 'at91-sama5d2_adc: merge buffer & trigger' patch in this series, > so that the removal of iio_buffer_set_attrs() is easier to view > > Alexandru Ardelean (9): > iio: buffer: dmaengine: unwrap the use of iio_buffer_set_attrs() > iio: adc: at91-sama5d2_adc: merge buffer & trigger init into a > function > iio: triggered-buffer: add {devm_}iio_triggered_buffer_setup_ext > variants > iio: accel: adxl372: use devm_iio_triggered_buffer_setup_ext() > iio: accel: bmc150: use iio_triggered_buffer_setup_ext() > iio: adc: at91-sama5d2_adc: use devm_iio_triggered_buffer_setup_ext() > iio: cros_ec: use devm_iio_triggered_buffer_setup_ext() > iio: hid-sensors: use iio_triggered_buffer_setup_ext() > iio: buffer: remove iio_buffer_set_attrs() helper > > drivers/iio/accel/adxl372.c | 11 ++- > drivers/iio/accel/bmc150-accel-core.c | 25 +++--- > drivers/iio/adc/at91-sama5d2_adc.c | 82 +++++++++---------- > .../buffer/industrialio-buffer-dmaengine.c | 3 +- > .../buffer/industrialio-triggered-buffer.c | 31 ++++--- > .../cros_ec_sensors/cros_ec_sensors_core.c | 15 ++-- > .../common/hid-sensors/hid-sensor-trigger.c | 22 ++--- > drivers/iio/industrialio-buffer.c | 12 --- > include/linux/iio/buffer.h | 3 - > include/linux/iio/triggered_buffer.h | 23 ++++-- > 10 files changed, 113 insertions(+), 114 deletions(-) > > -- > 2.17.1 >
On Tue, Sep 29, 2020 at 4:09 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Tue, Sep 29, 2020 at 3:55 PM Alexandru Ardelean > <alexandru.ardelean@analog.com> wrote: > > > > This is a v2 & v3 for [1]: > > https://lore.kernel.org/linux-iio/20200925083743.46469-1-alexandru.ardelean@analog.com/ > > > > It also includes a at91-sama5d2_adc cleanup patch in this series: > > https://lore.kernel.org/linux-iio/20200924102902.136169-1-alexandru.ardelean@analog.com/ > > This patch is required, in order to make the removal of > > iio_buffer_set_attrs() a bit cleaner in the at91-sama5d2_adc driver. > > > > Following the discussion from [1], this patchset implements the > > following: > > Makes sense to me, FWIW, > Reviewed-by: Andy Shevchenko <andy.shevchenjko> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
This is a v2 & v3 for [1]: https://lore.kernel.org/linux-iio/20200925083743.46469-1-alexandru.ardelean@analog.com/ It also includes a at91-sama5d2_adc cleanup patch in this series: https://lore.kernel.org/linux-iio/20200924102902.136169-1-alexandru.ardelean@analog.com/ This patch is required, in order to make the removal of iio_buffer_set_attrs() a bit cleaner in the at91-sama5d2_adc driver. Following the discussion from [1], this patchset implements the following: Changelog v2 -> v3: * in patch 'iio: buffer: dmaengine: unwrap the use of iio_buffer_set_attrs()' - minor stylistic change; Changelog v1 -> v2: * rename '{devm_}iio_triggered_buffer_setup()' -> '{devm_}iio_triggered_buffer_setup_ext()' - wrap with macros the new ext functions to preserve backwards compatibility - add a new parameter to the ext functions, which are the buffer->attrs * split into separate patches the removal [from each driver] of iio_buffer_set_attrs() and the switch to a {devm_}iio_triggered_buffer_setup_ext variant * add patch to remove iio_buffer_set_attrs() from DMAEngine IIO buffer * remove the iio_buffer_set_attrs() helper in a final/separate patch * add 'at91-sama5d2_adc: merge buffer & trigger' patch in this series, so that the removal of iio_buffer_set_attrs() is easier to view Alexandru Ardelean (9): iio: buffer: dmaengine: unwrap the use of iio_buffer_set_attrs() iio: adc: at91-sama5d2_adc: merge buffer & trigger init into a function iio: triggered-buffer: add {devm_}iio_triggered_buffer_setup_ext variants iio: accel: adxl372: use devm_iio_triggered_buffer_setup_ext() iio: accel: bmc150: use iio_triggered_buffer_setup_ext() iio: adc: at91-sama5d2_adc: use devm_iio_triggered_buffer_setup_ext() iio: cros_ec: use devm_iio_triggered_buffer_setup_ext() iio: hid-sensors: use iio_triggered_buffer_setup_ext() iio: buffer: remove iio_buffer_set_attrs() helper drivers/iio/accel/adxl372.c | 11 ++- drivers/iio/accel/bmc150-accel-core.c | 25 +++--- drivers/iio/adc/at91-sama5d2_adc.c | 82 +++++++++---------- .../buffer/industrialio-buffer-dmaengine.c | 3 +- .../buffer/industrialio-triggered-buffer.c | 31 ++++--- .../cros_ec_sensors/cros_ec_sensors_core.c | 15 ++-- .../common/hid-sensors/hid-sensor-trigger.c | 22 ++--- drivers/iio/industrialio-buffer.c | 12 --- include/linux/iio/buffer.h | 3 - include/linux/iio/triggered_buffer.h | 23 ++++-- 10 files changed, 113 insertions(+), 114 deletions(-)