diff mbox series

[-next] mm/vmscan: Drop duplicated code in drop_slab_node

Message ID 20200930020659.139283-1-wangkefeng.wang@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] mm/vmscan: Drop duplicated code in drop_slab_node | expand

Commit Message

Kefeng Wang Sept. 30, 2020, 2:06 a.m. UTC
The following patches fix same issue and both add fatal
signal check in drop_slab_node, kill a duplicated check.

  "mm/vmscan: add a fatal signals check in drop_slab_node"
  "mm/vmscan: fix infinite loop in drop_slab_node"

Cc: Chunxin Zang <zangchunxin@bytedance.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/vmscan.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Chunxin Zang Sept. 30, 2020, 2:42 a.m. UTC | #1
On Wed, Sep 30, 2020 at 10:07 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> The following patches fix same issue and both add fatal
> signal check in drop_slab_node, kill a duplicated check.
>
>   "mm/vmscan: add a fatal signals check in drop_slab_node"
>   "mm/vmscan: fix infinite loop in drop_slab_node"
>
> Cc: Chunxin Zang <zangchunxin@bytedance.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  mm/vmscan.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index eae57d092931..980155e257bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -699,9 +699,6 @@ void drop_slab_node(int nid)
>         do {
>                 struct mem_cgroup *memcg = NULL;
>
> -               if (fatal_signal_pending(current))
> -                       return;
> -
>                 if (fatal_signal_pending(current))
>                         return;
>
> --
> 2.26.2
>

Yes,  there are the same patch.  Because the 'add a fatal signals
check in drop_slab_node' description is more accurate.
The mail list  please see  https://lkml.org/lkml/2020/9/15/20

Andrew, can you update it ,  thanks so much.

Best wishes
Chunxin Zang
diff mbox series

Patch

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eae57d092931..980155e257bf 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -699,9 +699,6 @@  void drop_slab_node(int nid)
 	do {
 		struct mem_cgroup *memcg = NULL;
 
-		if (fatal_signal_pending(current))
-			return;
-
 		if (fatal_signal_pending(current))
 			return;