mbox series

[v2,0/6] kselftest: arm64/mte: Tests for user-space MTE

Message ID 20201002115630.24683-1-amit.kachhap@arm.com (mailing list archive)
Headers show
Series kselftest: arm64/mte: Tests for user-space MTE | expand

Message

Amit Daniel Kachhap Oct. 2, 2020, 11:56 a.m. UTC 
These patch series adds below kselftests to test the user-space support for the
ARMv8.5 Memory Tagging Extension present in arm64 tree [1]. This patch
series is based on Linux v5.9-rc3.

1) This test-case verifies that the memory allocated by kernel mmap interface
can support tagged memory access. It first checks the presence of tags at
address[56:59] and then proceeds with read and write. The pass criteria for
this test is that tag fault exception should not happen.

2) This test-case crosses the valid memory to the invalid memory. In this
memory area valid tags are not inserted so read and write should not pass. The
pass criteria for this test is that tag fault exception should happen for all
the illegal addresses. This test also verfies that PSTATE.TCO works properly.

3) This test-case verifies that the memory inherited by child process from
parent process should have same tags copied. The pass criteria for this test is
that tag fault exception should not happen.

4) This test checks different mmap flags with PROT_MTE memory protection.

5) This testcase checks that KSM should not merge pages containing different
MTE tag values. However, if the tags are same then the pages may merge. This
testcase uses the generic ksm sysfs interfaces to verify the MTE behaviour, so
this testcase is not fullproof and may be impacted due to other load in the system.

6) Fifth test verifies that syscalls read/write etc works by considering that
user pointer has valid/invalid allocation tags.

Changes since v1 [2]:
* Redefined MTE kernel header definitions to decouple kselftest compilations.
* Removed gmi masking instructions in mte_insert_random_tag assembly
  function. This simplifies the tag inclusion mask test with only GCR
  mask register used.
* Created a new mte_insert_random_tag function with gmi instruction.
  This is useful for the 6th test which reuses the original tag.
* Now use /dev/shm/* to hold temporary files.
* Updated the 6th test to handle the error properly in case of failure
  in accessing memory with invalid tag in kernel.
* Code and comment clean-ups.

Thanks,
Amit Daniel

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/mte
[2]: https://patchwork.kernel.org/patch/11747791/

Amit Daniel Kachhap (6):
  kselftest/arm64: Add utilities and a test to validate mte memory
  kselftest/arm64: Verify mte tag inclusion via prctl
  kselftest/arm64: Check forked child mte memory accessibility
  kselftest/arm64: Verify all different mmap MTE options
  kselftest/arm64: Verify KSM page merge for MTE pages
  kselftest/arm64: Check mte tagged user address in kernel

 tools/testing/selftests/arm64/Makefile        |   2 +-
 tools/testing/selftests/arm64/mte/.gitignore  |   6 +
 tools/testing/selftests/arm64/mte/Makefile    |  29 ++
 .../selftests/arm64/mte/check_buffer_fill.c   | 475 ++++++++++++++++++
 .../selftests/arm64/mte/check_child_memory.c  | 195 +++++++
 .../selftests/arm64/mte/check_ksm_options.c   | 159 ++++++
 .../selftests/arm64/mte/check_mmap_options.c  | 262 ++++++++++
 .../arm64/mte/check_tags_inclusion.c          | 185 +++++++
 .../selftests/arm64/mte/check_user_mem.c      | 111 ++++
 .../selftests/arm64/mte/mte_common_util.c     | 341 +++++++++++++
 .../selftests/arm64/mte/mte_common_util.h     | 118 +++++
 tools/testing/selftests/arm64/mte/mte_def.h   |  60 +++
 .../testing/selftests/arm64/mte/mte_helper.S  | 128 +++++
 13 files changed, 2070 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/arm64/mte/.gitignore
 create mode 100644 tools/testing/selftests/arm64/mte/Makefile
 create mode 100644 tools/testing/selftests/arm64/mte/check_buffer_fill.c
 create mode 100644 tools/testing/selftests/arm64/mte/check_child_memory.c
 create mode 100644 tools/testing/selftests/arm64/mte/check_ksm_options.c
 create mode 100644 tools/testing/selftests/arm64/mte/check_mmap_options.c
 create mode 100644 tools/testing/selftests/arm64/mte/check_tags_inclusion.c
 create mode 100644 tools/testing/selftests/arm64/mte/check_user_mem.c
 create mode 100644 tools/testing/selftests/arm64/mte/mte_common_util.c
 create mode 100644 tools/testing/selftests/arm64/mte/mte_common_util.h
 create mode 100644 tools/testing/selftests/arm64/mte/mte_def.h
 create mode 100644 tools/testing/selftests/arm64/mte/mte_helper.S

Comments

Catalin Marinas Oct. 2, 2020, 6 p.m. UTC | #1 
On Fri, Oct 02, 2020 at 05:26:24PM +0530, Amit Daniel Kachhap wrote:
> Amit Daniel Kachhap (6):
>   kselftest/arm64: Add utilities and a test to validate mte memory
>   kselftest/arm64: Verify mte tag inclusion via prctl
>   kselftest/arm64: Check forked child mte memory accessibility
>   kselftest/arm64: Verify all different mmap MTE options
>   kselftest/arm64: Verify KSM page merge for MTE pages
>   kselftest/arm64: Check mte tagged user address in kernel

Thanks Amit for respinning the series. Tested on FVP (some Qemu bugs get
in the way and they fail).

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Tested-by: Catalin Marinas <catalin.marinas@arm.com>
Will Deacon Oct. 5, 2020, 6:08 p.m. UTC | #2 
On Fri, 2 Oct 2020 17:26:24 +0530, Amit Daniel Kachhap wrote:
> These patch series adds below kselftests to test the user-space support for the
> ARMv8.5 Memory Tagging Extension present in arm64 tree [1]. This patch
> series is based on Linux v5.9-rc3.
> 
> 1) This test-case verifies that the memory allocated by kernel mmap interface
> can support tagged memory access. It first checks the presence of tags at
> address[56:59] and then proceeds with read and write. The pass criteria for
> this test is that tag fault exception should not happen.
> 
> [...]

Applied to arm64 (for-next/late-arrivals), thanks!

[1/6] kselftest/arm64: Add utilities and a test to validate mte memory
      https://git.kernel.org/arm64/c/e9b60476bea0
[2/6] kselftest/arm64: Verify mte tag inclusion via prctl
      https://git.kernel.org/arm64/c/f3b2a26ca78d
[3/6] kselftest/arm64: Check forked child mte memory accessibility
      https://git.kernel.org/arm64/c/dfe537cf4718
[4/6] kselftest/arm64: Verify all different mmap MTE options
      https://git.kernel.org/arm64/c/53ec81d23213
[5/6] kselftest/arm64: Verify KSM page merge for MTE pages
      https://git.kernel.org/arm64/c/f981d8fa2646
[6/6] kselftest/arm64: Check mte tagged user address in kernel
      https://git.kernel.org/arm64/c/4dafc08d0ba4

Cheers,