| Message ID | CACPK8XcP_j7q+jWN6_JGaEcfPy=zSQHyizp1LOw05zFB4L9iGQ@mail.gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [GIT,PULL] ARM: aspeed: soc changes for 5.10 | expand |
Hi Joel, On Fri, Sep 25, 2020 at 06:31:28AM +0000, Joel Stanley wrote: > Hello Soc maintainers, > > Here are some ASPEED changes for the 5.10 merge window. > > The following changes since commit e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: > > soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > tags/aspeed-5.10-soc > > for you to fetch changes up to e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: > > soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) > > ---------------------------------------------------------------- > ASPEED soc driver updates for 5.10 > > New drivers: > > - XDMA driver for the BMC to host PCIe DMA device I don't think this driver belongs in drivers/soc, it's not "soc glue logic", and it has a userspace interface. Some of the commits even references it as a "misc driver". Mind resubmitting it for drivers/misc instead? Thanks, -Olof
On Sat, 3 Oct 2020 at 20:31, Olof Johansson <olof@lixom.net> wrote: > > Hi Joel, > > On Fri, Sep 25, 2020 at 06:31:28AM +0000, Joel Stanley wrote: > > Hello Soc maintainers, > > > > Here are some ASPEED changes for the 5.10 merge window. > > > > The following changes since commit e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: > > > > soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > > tags/aspeed-5.10-soc > > > > for you to fetch changes up to e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: > > > > soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) > > > > ---------------------------------------------------------------- > > ASPEED soc driver updates for 5.10 > > > > New drivers: > > > > - XDMA driver for the BMC to host PCIe DMA device > > I don't think this driver belongs in drivers/soc, it's not "soc glue > logic", and it has a userspace interface. Some of the commits even > references it as a "misc driver". Mind resubmitting it for drivers/misc > instead? (Argh I missed this mail) We used to have the various little drivers in drivers/misc, but somewhere along the line we decided to move them to drivers/soc. I think that was Arnd asking Patrick Venture? https://lore.kernel.org/linux-arm-kernel/CAK8P3a3CK4o8KnD6M084ULEmm+6_CtNFqYHjSqE5vp+U9YAmkA@mail.gmail.com/ The existing drivers have userspace interfaces for misc parts of the aspeed chip, mostly relating to the strange (from a traditional Linux/host perspective) interfaces it exposes to the host. This XDMA driver should go alongside those other drivers. With that context, how would you like to proceed? Cheers, Joel
On Wed, 7 Oct 2020 at 11:18, Joel Stanley <joel@jms.id.au> wrote: > > On Sat, 3 Oct 2020 at 20:31, Olof Johansson <olof@lixom.net> wrote: > > > > Hi Joel, > > > > On Fri, Sep 25, 2020 at 06:31:28AM +0000, Joel Stanley wrote: > > > Hello Soc maintainers, > > > > > > Here are some ASPEED changes for the 5.10 merge window. > > > > > > The following changes since commit e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: > > > > > > soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > > > tags/aspeed-5.10-soc > > > > > > for you to fetch changes up to e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: > > > > > > soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) > > > > > > ---------------------------------------------------------------- > > > ASPEED soc driver updates for 5.10 > > > > > > New drivers: > > > > > > - XDMA driver for the BMC to host PCIe DMA device > > > > I don't think this driver belongs in drivers/soc, it's not "soc glue > > logic", and it has a userspace interface. Some of the commits even > > references it as a "misc driver". Mind resubmitting it for drivers/misc > > instead? > > (Argh I missed this mail) > > We used to have the various little drivers in drivers/misc, but > somewhere along the line we decided to move them to drivers/soc. I > think that was Arnd asking Patrick Venture? > > https://lore.kernel.org/linux-arm-kernel/CAK8P3a3CK4o8KnD6M084ULEmm+6_CtNFqYHjSqE5vp+U9YAmkA@mail.gmail.com/ > > The existing drivers have userspace interfaces for misc parts of the > aspeed chip, mostly relating to the strange (from a traditional > Linux/host perspective) interfaces it exposes to the host. This XDMA > driver should go alongside those other drivers. > > With that context, how would you like to proceed? Arnd, Olof, what would you like to do here? Cheers, Joel
Hello Soc maintainers, Here are some ASPEED changes for the 5.10 merge window. The following changes since commit e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git tags/aspeed-5.10-soc for you to fetch changes up to e55f541e51b5136fc0ced0bdf2b33ee3cca3bc96: soc: aspeed: xdma: Add reset ioctl (2020-09-25 15:32:57 +0930) ---------------------------------------------------------------- ASPEED soc driver updates for 5.10 New drivers: - XDMA driver for the BMC to host PCIe DMA device - SoC info driver to expose revision information New features: - AST2600 support for the LPC control driver. This includes setting the LPC2AHB bridge up in a backwards compatible manner. Cleanups: - LPC control - Kconfig - Bindings updates for AST2600 strings ---------------------------------------------------------------- Andrew Jeffery (1): soc: aspeed-lpc-ctrl: Fail probe of lpc-ctrl if reserved memory is not aligned Brad Bishop (2): dt-bindings: aspeed-lpc: Add AST2600 compatible strings soc: aspeed: lpc: Add AST2600 compatible strings Eddie James (4): dt-bindings: soc: Add Aspeed XDMA Engine soc: aspeed: Add XDMA Engine Driver soc: aspeed: xdma: Add user interface soc: aspeed: xdma: Add reset ioctl Joel Stanley (7): soc: aspeed: Improve kconfig dt-bindings: aspeed: Add silicon id node to SCU soc: aspeed: Add soc info driver ARM: dts: aspeed: Add silicon id node soc: aspeed-lpc-ctrl: LPC to AHB mapping on ast2600 soc: aspeed-lpc-ctrl: Fix whitespace soc: aspeed-lpc-ctrl: Fix driver name .../devicetree/bindings/mfd/aspeed-lpc.txt | 8 +- .../devicetree/bindings/mfd/aspeed-scu.txt | 26 + .../devicetree/bindings/soc/aspeed/xdma.yaml | 103 ++ MAINTAINERS | 8 + arch/arm/boot/dts/aspeed-g4.dtsi | 5 + arch/arm/boot/dts/aspeed-g5.dtsi | 5 + arch/arm/boot/dts/aspeed-g6.dtsi | 5 + drivers/soc/Makefile | 2 +- drivers/soc/aspeed/Kconfig | 53 +- drivers/soc/aspeed/Makefile | 2 + drivers/soc/aspeed/aspeed-lpc-ctrl.c | 37 +- drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 + drivers/soc/aspeed/aspeed-socinfo.c | 133 +++ drivers/soc/aspeed/aspeed-xdma.c | 1205 ++++++++++++++++++++ include/uapi/linux/aspeed-xdma.h | 42 + 15 files changed, 1615 insertions(+), 21 deletions(-)