| Message ID | 1602412498-32025-2-git-send-email-Julia.Lawall@inria.fr (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net: use semicolons rather than commas to separate statements | expand |
Julia Lawall <Julia.Lawall@inria.fr> wrote: > - call->completion = compl, > + call->completion = compl; Looks good. Do you want me to pick up the patch or send it yourself? If the latter: Acked-by: David Howells <dhowells@redhat.com>
On Mon, 12 Oct 2020, David Howells wrote: > Julia Lawall <Julia.Lawall@inria.fr> wrote: > > > - call->completion = compl, > > + call->completion = compl; > > Looks good. Do you want me to pick up the patch or send it yourself? Please pick it up. Thanks. julia > > If the latter: > > Acked-by: David Howells <dhowells@redhat.com> > >
diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c index c4684dde1f16..acc4660cfa5b 100644 --- a/net/rxrpc/recvmsg.c +++ b/net/rxrpc/recvmsg.c @@ -69,7 +69,7 @@ bool __rxrpc_set_call_completion(struct rxrpc_call *call, if (call->state < RXRPC_CALL_COMPLETE) { call->abort_code = abort_code; call->error = error; - call->completion = compl, + call->completion = compl; call->state = RXRPC_CALL_COMPLETE; trace_rxrpc_call_complete(call); wake_up(&call->waitq);
Replace commas with semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // <smpl> @@ expression e1,e2; @@ e1 -, +; e2 ... when any // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> --- net/rxrpc/recvmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)