diff mbox series

net/af_unix: Remove unused old_pid variable

Message ID 20201011153527.18628-1-orcohen@paloaltonetworks.com (mailing list archive)
State Not Applicable
Headers show
Series net/af_unix: Remove unused old_pid variable | expand

Commit Message

Or Cohen Oct. 11, 2020, 3:35 p.m. UTC 
Commit 109f6e39fa07c48f5801 ("af_unix: Allow SO_PEERCRED
to work across namespaces.") introduced the old_pid variable
in unix_listen, but it's never used.
Remove the declaration and the call to put_pid.

Signed-off-by: Or Cohen <orcohen@paloaltonetworks.com>
---
 net/unix/af_unix.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Jakub Kicinski Oct. 14, 2020, 12:24 a.m. UTC | #1 
On Sun, 11 Oct 2020 18:35:27 +0300 Or Cohen wrote:
> Commit 109f6e39fa07c48f5801 ("af_unix: Allow SO_PEERCRED
> to work across namespaces.") introduced the old_pid variable
> in unix_listen, but it's never used.
> Remove the declaration and the call to put_pid.
> 
> Signed-off-by: Or Cohen <orcohen@paloaltonetworks.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 3385a7a0b231..26d3bf81186f 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -613,7 +613,6 @@  static int unix_listen(struct socket *sock, int backlog)
 	int err;
 	struct sock *sk = sock->sk;
 	struct unix_sock *u = unix_sk(sk);
-	struct pid *old_pid = NULL;
 
 	err = -EOPNOTSUPP;
 	if (sock->type != SOCK_STREAM && sock->type != SOCK_SEQPACKET)
@@ -634,7 +633,6 @@  static int unix_listen(struct socket *sock, int backlog)
 
 out_unlock:
 	unix_state_unlock(sk);
-	put_pid(old_pid);
 out:
 	return err;
 }