| Message ID | 20201016134320.20321-4-qiangqing.zhang@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | can: flexcan: add stop mode support for i.MX8QM | expand |
On 10/16/20 3:43 PM, Joakim Zhang wrote: > For SoCs with SCU support, need setup stop mode via SCU firmware, > so this property can help indicate a resource. > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > --- > Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > index 6af67f5e581c..839c0c0064a2 100644 > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > @@ -43,6 +43,10 @@ Optional properties: > 0: clock source 0 (oscillator clock) > 1: clock source 1 (peripheral clock) > > +- fsl,can-index: The index of CAN instance. > + For SoCs with SCU support, need setup stop mode via SCU firmware, > + so this property can help indicate a resource. This property is not CAN specific. So the name could be more general. > + > - wakeup-source: enable CAN remote wakeup > > Example: > @@ -54,4 +58,5 @@ Example: > interrupt-parent = <&mpic>; > clock-frequency = <200000000>; // filled in by bootloader > fsl,clk-source = /bits/ 8 <0>; // select clock source 0 for PE > + fsl,can-index = /bits/ 8 <1>; // the second CAN instance > }; > Marc
Hi Marc, > -----Original Message----- > From: Marc Kleine-Budde <mkl@pengutronix.de> > Sent: 2020年10月16日 14:20 > To: Joakim Zhang <qiangqing.zhang@nxp.com>; robh+dt@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de > Cc: devicetree@vger.kernel.org; Peng Fan <peng.fan@nxp.com>; Ying Liu > <victor.liu@nxp.com>; netdev@vger.kernel.org; Pankaj Bansal > <pankaj.bansal@nxp.com>; linux-kernel@vger.kernel.org; > linux-can@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; > kernel@pengutronix.de > Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property > to indicate a resource > > On 10/16/20 3:43 PM, Joakim Zhang wrote: > > For SoCs with SCU support, need setup stop mode via SCU firmware, so > > this property can help indicate a resource. > > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > > --- > > Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > > b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > > index 6af67f5e581c..839c0c0064a2 100644 > > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > > +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt > > @@ -43,6 +43,10 @@ Optional properties: > > 0: clock source 0 (oscillator clock) > > 1: clock source 1 (peripheral clock) > > > > +- fsl,can-index: The index of CAN instance. > > + For SoCs with SCU support, need setup stop mode via > SCU firmware, > > + so this property can help indicate a resource. > > This property is not CAN specific. So the name could be more general. How about "fsl,index"? Best Regards, Joakim Zhang > > + > > - wakeup-source: enable CAN remote wakeup > > > > Example: > > @@ -54,4 +58,5 @@ Example: > > interrupt-parent = <&mpic>; > > clock-frequency = <200000000>; // filled in by bootloader > > fsl,clk-source = /bits/ 8 <0>; // select clock source 0 for PE > > + fsl,can-index = /bits/ 8 <1>; // the second CAN instance > > }; > > > > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On 10/16/20 8:52 AM, Joakim Zhang wrote: > > Hi Marc, > >> -----Original Message----- >> From: Marc Kleine-Budde <mkl@pengutronix.de> >> Sent: 2020年10月16日 14:20 >> To: Joakim Zhang <qiangqing.zhang@nxp.com>; robh+dt@kernel.org; >> shawnguo@kernel.org; s.hauer@pengutronix.de >> Cc: devicetree@vger.kernel.org; Peng Fan <peng.fan@nxp.com>; Ying Liu >> <victor.liu@nxp.com>; netdev@vger.kernel.org; Pankaj Bansal >> <pankaj.bansal@nxp.com>; linux-kernel@vger.kernel.org; >> linux-can@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; >> kernel@pengutronix.de >> Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property >> to indicate a resource >> >> On 10/16/20 3:43 PM, Joakim Zhang wrote: >>> For SoCs with SCU support, need setup stop mode via SCU firmware, so >>> this property can help indicate a resource. >>> >>> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> >>> --- >>> Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >>> b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >>> index 6af67f5e581c..839c0c0064a2 100644 >>> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >>> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt >>> @@ -43,6 +43,10 @@ Optional properties: >>> 0: clock source 0 (oscillator clock) >>> 1: clock source 1 (peripheral clock) >>> >>> +- fsl,can-index: The index of CAN instance. >>> + For SoCs with SCU support, need setup stop mode via >> SCU firmware, >>> + so this property can help indicate a resource. >> >> This property is not CAN specific. So the name could be more general. > > How about "fsl,index"? Maybe something with "scu", as it's specific to the SCU firmware. I think it's up to Rob's and the DT people. Marc
diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt index 6af67f5e581c..839c0c0064a2 100644 --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt @@ -43,6 +43,10 @@ Optional properties: 0: clock source 0 (oscillator clock) 1: clock source 1 (peripheral clock) +- fsl,can-index: The index of CAN instance. + For SoCs with SCU support, need setup stop mode via SCU firmware, + so this property can help indicate a resource. + - wakeup-source: enable CAN remote wakeup Example: @@ -54,4 +58,5 @@ Example: interrupt-parent = <&mpic>; clock-frequency = <200000000>; // filled in by bootloader fsl,clk-source = /bits/ 8 <0>; // select clock source 0 for PE + fsl,can-index = /bits/ 8 <1>; // the second CAN instance };
For SoCs with SCU support, need setup stop mode via SCU firmware, so this property can help indicate a resource. Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> --- Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++ 1 file changed, 5 insertions(+)