| Message ID | 20201016171603.10587-1-ceggers@arri.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags | expand |
On Fri, Oct 16, 2020 at 07:16:03PM +0200, Christian Eggers wrote: > I added it manually because the commit ID is not from Linus' tree. Is there any > value using Fixes tags with id's from other trees? Yes, that's what "git merge" does, it keeps sha1sums. You should check out "git log --oneline --graph --decorate" some time. Every maintainer's history is linear, and so is Linus's.
On Fri, 16 Oct 2020 20:24:49 +0300 Vladimir Oltean wrote: > On Fri, Oct 16, 2020 at 07:16:03PM +0200, Christian Eggers wrote: > > I added it manually because the commit ID is not from Linus' tree. Is there any > > value using Fixes tags with id's from other trees? > > Yes, that's what "git merge" does, it keeps sha1sums. > You should check out "git log --oneline --graph --decorate" some time. > Every maintainer's history is linear, and so is Linus's. One thing to add is that we never rebase net or net-next trees (some maintainers would do that occasionally). Applied, thanks everyone!
diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index 945a9bd5ba35..0a5aa982c60d 100644 --- a/net/dsa/tag_ksz.c +++ b/net/dsa/tag_ksz.c @@ -123,6 +123,7 @@ static const struct dsa_device_ops ksz8795_netdev_ops = { .xmit = ksz8795_xmit, .rcv = ksz8795_rcv, .overhead = KSZ_INGRESS_TAG_LEN, + .tail_tag = true, }; DSA_TAG_DRIVER(ksz8795_netdev_ops); @@ -199,6 +200,7 @@ static const struct dsa_device_ops ksz9477_netdev_ops = { .xmit = ksz9477_xmit, .rcv = ksz9477_rcv, .overhead = KSZ9477_INGRESS_TAG_LEN, + .tail_tag = true, }; DSA_TAG_DRIVER(ksz9477_netdev_ops);
The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and KSZ9893 switches also use tail tags. Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers") Signed-off-by: Christian Eggers <ceggers@arri.de> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> --- On Friday, 16 October 2020, 18:56:51 CEST, Vladimir Oltean wrote: > Hi Christian, > > The idea is perfect but the commit isn't. > ... > Now if you run > "git show 7a6ffe764be35af0527d8cfd047945e8f8797ddf --pretty=fixes", > you'll see: > > Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers") thanks for pointing out how to use this feature. I did this manually up to now. > Notice how there's no [net] tag? > People complain when the format of the Fixes: tag is not standardized. I added it manually because the commit ID is not from Linus' tree. Is there any value using Fixes tags with id's from other trees? regards Christian net/dsa/tag_ksz.c | 2 ++ 1 file changed, 2 insertions(+)