[01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string

Commit Message

Serge Semin Oct. 20, 2020, 11:59 a.m. UTC

Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix.
Discard a DW USB3 compatible string with the deprecated prefix seeing
one isn't used by any dts file anymore.

Signed-off-by: Serge Semin <[e-mail]>
---
 drivers/usb/dwc3/core.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Andy Shevchenko Oct. 20, 2020, 12:15 p.m. UTC | #1

On Tue, Oct 20, 2020 at 3:02 PM Serge Semin
<[e-mail]> wrote:
>
> Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix.
> Discard a DW USB3 compatible string with the deprecated prefix seeing
> one isn't used by any dts file anymore.

I'm afraid it's no go.
It's an ABI from the moment when the driver started supporting this
compatible string.

Felipe Balbi Oct. 20, 2020, 12:27 p.m. UTC | #2

Hi,

Serge Semin <[e-mail]> writes:
> Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix.
> Discard a DW USB3 compatible string with the deprecated prefix seeing
> one isn't used by any dts file anymore.
>
> Signed-off-by: Serge Semin <[e-mail]>
> ---
>  drivers/usb/dwc3/core.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 2eb34c8b4065..28440250e798 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1878,9 +1878,6 @@ static const struct of_device_id of_dwc3_match[] = {
>  	{
>  		.compatible = "snps,dwc3"
>  	},
> -	{
> -		.compatible = "synopsys,dwc3"
> -	},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, of_dwc3_match);

sorry, no. You can't guarantee that there isn't a FW in ROM somewhere
using the old string.

Krzysztof Kozlowski Oct. 20, 2020, 12:28 p.m. UTC | #3

On Tue, Oct 20, 2020 at 03:15:06PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 20, 2020 at 3:02 PM Serge Semin
> <[e-mail]> wrote:
> >
> > Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix.
> > Discard a DW USB3 compatible string with the deprecated prefix seeing
> > one isn't used by any dts file anymore.
> 
> I'm afraid it's no go.
> It's an ABI from the moment when the driver started supporting this
> compatible string.

Exactly.

Please mark the compatible as deprecated in bindings, correct the DTSes
and optionally after one or two years (or any time later) remove the
support for deprecated bindings.

Best regards,
Krzysztof

Serge Semin Oct. 20, 2020, 12:33 p.m. UTC | #4

On Tue, Oct 20, 2020 at 02:28:01PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Oct 20, 2020 at 03:15:06PM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 20, 2020 at 3:02 PM Serge Semin
> > <[e-mail]> wrote:
> > >
> > > Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix.
> > > Discard a DW USB3 compatible string with the deprecated prefix seeing
> > > one isn't used by any dts file anymore.
> > 

> > I'm afraid it's no go.
> > It's an ABI from the moment when the driver started supporting this
> > compatible string.
> 
> Exactly.
> 
> Please mark the compatible as deprecated in bindings, correct the DTSes
> and optionally after one or two years (or any time later) remove the
> support for deprecated bindings.

Ok. I'll just get the original patch back then:
https://lore.kernel.org/linux-usb/[e-mail]/T/#m0f92acafbd740e63b7156efac58850e0757d2110
and resend the series later after the rest of the patchset have been cooked
a bit.

-Sergey

> 
> Best regards,
> Krzysztof
>

Patch

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 2eb34c8b4065..28440250e798 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1878,9 +1878,6 @@  static const struct of_device_id of_dwc3_match[] = {
 	{
 		.compatible = "snps,dwc3"
 	},
-	{
-		.compatible = "synopsys,dwc3"
-	},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, of_dwc3_match);