| Message ID | 20201020115959.2658-6-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string | expand |
On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote: > In accordance with the DWC USB3 bindings the property is supposed to have > uint32 type. It's erroneous from the DT schema and driver points of view > to declare it as boolean. I think the driver uses it as u32, so what do you mean by "declare" in context of a driver? Best regards, Krzysztof
On Tue, Oct 20, 2020 at 02:34:04PM +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote: > > In accordance with the DWC USB3 bindings the property is supposed to have > > uint32 type. It's erroneous from the DT schema and driver points of view > > to declare it as boolean. > > I think the driver uses it as u32, so what do you mean by "declare" in > context of a driver? I meant that both the driver and DT schema expects it to be uint32, while the dts has got the property as boolean, which is wrong. The same problem has been fixed in the Amlogic Meson-g12 DT schema example: https://lore.kernel.org/linux-usb/20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru/T/#m225585212162b9f5cccb1a7088850fab8792b7b3 -Sergey > > Best regards, > Krzysztof
On Tue, Oct 20, 2020 at 03:44:04PM +0300, Serge Semin wrote: > On Tue, Oct 20, 2020 at 02:34:04PM +0200, Krzysztof Kozlowski wrote: > > On Tue, Oct 20, 2020 at 02:59:35PM +0300, Serge Semin wrote: > > > In accordance with the DWC USB3 bindings the property is supposed to have > > > uint32 type. It's erroneous from the DT schema and driver points of view > > > to declare it as boolean. > > > > > I think the driver uses it as u32, so what do you mean by "declare" in > > context of a driver? > > I meant that both the driver and DT schema expects it to be uint32, while the > dts has got the property as boolean, which is wrong. The same problem has > been fixed in the Amlogic Meson-g12 DT schema example: > https://lore.kernel.org/linux-usb/20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru/T/#m225585212162b9f5cccb1a7088850fab8792b7b3 Ah, I got it. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
Hi Serge, On 20/10/2020 13:59, Serge Semin wrote: > In accordance with the DWC USB3 bindings the property is supposed to have > uint32 type. It's erroneous from the DT schema and driver points of view > to declare it as boolean. As Neil suggested set it to 0x20 so not break > the platform and to make the dtbs checker happy. > > Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/ > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > index 1e83ec5b8c91..3033ab2be1ff 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > @@ -2380,7 +2380,7 @@ dwc3: usb@ff500000 { > interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > dr_mode = "host"; > snps,dis_u2_susphy_quirk; > - snps,quirk-frame-length-adjustment; > + snps,quirk-frame-length-adjustment = <0x20>; > snps,parkmode-disable-ss-quirk; > }; > }; > You were faster than me ! Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
On Tue, Oct 20, 2020 at 2:00 PM Serge Semin <Sergey.Semin@baikalelectronics.ru> wrote: > > In accordance with the DWC USB3 bindings the property is supposed to have > uint32 type. It's erroneous from the DT schema and driver points of view > to declare it as boolean. As Neil suggested set it to 0x20 so not break > the platform and to make the dtbs checker happy. > > Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/ > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi index 1e83ec5b8c91..3033ab2be1ff 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi @@ -2380,7 +2380,7 @@ dwc3: usb@ff500000 { interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; dr_mode = "host"; snps,dis_u2_susphy_quirk; - snps,quirk-frame-length-adjustment; + snps,quirk-frame-length-adjustment = <0x20>; snps,parkmode-disable-ss-quirk; }; };
In accordance with the DWC USB3 bindings the property is supposed to have uint32 type. It's erroneous from the DT schema and driver points of view to declare it as boolean. As Neil suggested set it to 0x20 so not break the platform and to make the dtbs checker happy. Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/ Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)