| Message ID | 20201019224649.14302-1-khilman@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] soc: mx-socinfo: only build for arm | expand |
On Tue 20 Oct 2020 at 00:46, Kevin Hilman <khilman@baylibre.com> wrote: > This driver only supports 32-bit ARM SoCs. Only build it for those. > > Signed-off-by: Kevin Hilman <khilman@baylibre.com> > --- > drivers/soc/amlogic/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig > index 321c5e26a268..2d7ee1397d59 100644 > --- a/drivers/soc/amlogic/Kconfig > +++ b/drivers/soc/amlogic/Kconfig > @@ -63,7 +63,7 @@ config MESON_SECURE_PM_DOMAINS > > config MESON_MX_SOCINFO > bool "Amlogic Meson MX SoC Information driver" > - depends on ARCH_MESON || COMPILE_TEST > + depends on (ARM && ARCH_MESON) || COMPILE_TEST Would to it make sense to apply the same to the GX soc info ? depends on ARM64 ? > default ARCH_MESON > select SOC_BUS > help Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Jerome Brunet <jbrunet@baylibre.com> writes: > On Tue 20 Oct 2020 at 00:46, Kevin Hilman <khilman@baylibre.com> wrote: > >> This driver only supports 32-bit ARM SoCs. Only build it for those. >> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> --- >> drivers/soc/amlogic/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig >> index 321c5e26a268..2d7ee1397d59 100644 >> --- a/drivers/soc/amlogic/Kconfig >> +++ b/drivers/soc/amlogic/Kconfig >> @@ -63,7 +63,7 @@ config MESON_SECURE_PM_DOMAINS >> >> config MESON_MX_SOCINFO >> bool "Amlogic Meson MX SoC Information driver" >> - depends on ARCH_MESON || COMPILE_TEST >> + depends on (ARM && ARCH_MESON) || COMPILE_TEST > > Would to it make sense to apply the same to the GX soc info ? depends on > ARM64 ? Yes, good point. I'll update that. >> default ARCH_MESON >> select SOC_BUS >> help > > Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> Thanks for the review, Kevin
On Tue, Oct 20, 2020 at 12:47 AM Kevin Hilman <khilman@baylibre.com> wrote: > > This driver only supports 32-bit ARM SoCs. Only build it for those. > > Signed-off-by: Kevin Hilman <khilman@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig index 321c5e26a268..2d7ee1397d59 100644 --- a/drivers/soc/amlogic/Kconfig +++ b/drivers/soc/amlogic/Kconfig @@ -63,7 +63,7 @@ config MESON_SECURE_PM_DOMAINS config MESON_MX_SOCINFO bool "Amlogic Meson MX SoC Information driver" - depends on ARCH_MESON || COMPILE_TEST + depends on (ARM && ARCH_MESON) || COMPILE_TEST default ARCH_MESON select SOC_BUS help
This driver only supports 32-bit ARM SoCs. Only build it for those. Signed-off-by: Kevin Hilman <khilman@baylibre.com> --- drivers/soc/amlogic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)