| Message ID | 1603269094-29367-1-git-send-email-peng.fan@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: imx: fix bus critical clk registration | expand |
On 20-10-21 16:31:29, peng.fan@nxp.com wrote: > From: Peng Fan <peng.fan@nxp.com> > > The issue is exposed by > https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/ > linux.git/commit/?h=for-next&id=936c383673b9e3007432f17140ac62de53d87db9 > > Since the upper patch not in Linus tree, I not add Fixed tag. > > The issue is bus clk should be registered using bus composite api, not > peripheral api. Otherwise we will met failed to assigned clock parents error log. > Because peripheral critical clk has CLK_SET_PARENT_GATE and CLK_IS_CRITICAL, > you will not able to set clk parents. > > We need use bus critical clk api to register the clks, so introduce > a new helper and use it. > I already had this change in the devfreq+icc tree. Thanks for speeding up this work. After our discussion yesterday, there is a further change needed for the bus clocks and that is the 'right' to reparent on rate change. I'll probably send that myself. For this entire series: Reviewed-by: Abel Vesa <abel.vesa@nxp.com> > Peng Fan (5): > clk: imx: add imx8m_clk_hw_composite_bus_critical > clk: imx8mq: fix noc and noc_io registration > clk: imx8mm: fix bus critical clk registration > clk: imx8mn: fix bus critical clk registration > clk: imx8mp: fix bus critical clk registration > > drivers/clk/imx/clk-imx8mm.c | 10 +++++----- > drivers/clk/imx/clk-imx8mn.c | 6 +++--- > drivers/clk/imx/clk-imx8mp.c | 10 +++++----- > drivers/clk/imx/clk-imx8mq.c | 8 ++++---- > drivers/clk/imx/clk.h | 5 +++++ > 5 files changed, 22 insertions(+), 17 deletions(-) > > -- > 2.28.0 >
From: Peng Fan <peng.fan@nxp.com> The issue is exposed by https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/ linux.git/commit/?h=for-next&id=936c383673b9e3007432f17140ac62de53d87db9 Since the upper patch not in Linus tree, I not add Fixed tag. The issue is bus clk should be registered using bus composite api, not peripheral api. Otherwise we will met failed to assigned clock parents error log. Because peripheral critical clk has CLK_SET_PARENT_GATE and CLK_IS_CRITICAL, you will not able to set clk parents. We need use bus critical clk api to register the clks, so introduce a new helper and use it. Peng Fan (5): clk: imx: add imx8m_clk_hw_composite_bus_critical clk: imx8mq: fix noc and noc_io registration clk: imx8mm: fix bus critical clk registration clk: imx8mn: fix bus critical clk registration clk: imx8mp: fix bus critical clk registration drivers/clk/imx/clk-imx8mm.c | 10 +++++----- drivers/clk/imx/clk-imx8mn.c | 6 +++--- drivers/clk/imx/clk-imx8mp.c | 10 +++++----- drivers/clk/imx/clk-imx8mq.c | 8 ++++---- drivers/clk/imx/clk.h | 5 +++++ 5 files changed, 22 insertions(+), 17 deletions(-)