mbox series

[v7,00/12] leds: pwm: Make automatic labels work

Message ID 20201005203451.9985-1-post@lespocky.de (mailing list archive)
Headers show
Series leds: pwm: Make automatic labels work | expand

Message

Alexander Dahl Oct. 5, 2020, 8:34 p.m. UTC 
Hei hei,

for leds-gpio you can use the properties 'function' and 'color' in the
devicetree node and omit 'label', the label is constructed
automatically.  This is a common feature supposed to be working for all
LED drivers.  However it did not work until recently for the 'leds-pwm'
driver.

This series removes the no more needed platform_data support from the
leds-pwm driver, which was a precondition for the already applied patch
actually making automatic naming work.

The leds-pwm dt-bindings are converted and updated to reflect the
possibility to use led function and color for naming now.

v7 of this series is basically collecting reviewed-by tags, split old
patch 5/7 into per arm sub-arch changes for easier maintainer review,
and rewording commit messages.  See each patch for a detailed changelog.

For the bindings conversion it's now required to explicitly set a
license.  Peter, Russel, could you please acknowledge that patch?

Series changelog below …

Greets
Alex

v7:
- rebased series on recent pavel/for-next
- split up arm dts patch by arm sub arch (suggested by Krzysztof Kozlowski)
- added multiple Reviewed-by tags
- slightly reworded commit messages (suggested by Krzysztof Kozlowski)
- added actual dtbs_check warnings to commit messages
- added Russell King to Cc for binding conversion patch (because license)

v6:
- rebased series on recent pavel/for-next
- added Reviewed-by from Marek to patch 1
- patch 2 from v5 was picked by Pavel and is already in his for-next
  branch
- previous patch 3/3 (now 2/7) was reworked based on feedback by Rob
- added more dt patches fixing warnings after binding conversion to yaml

v5:
- replaced patch 1/3 by a new patch removing platform_data support for
  the leds-pwm driver
- little rewording of commit message in patch 2/3
- updated patch 3/3 based on feedback by Rob Herring
- added Marek Behún to Cc, because he also works on removing
  platform_data support
- rebased series on pavel/for-next

v4:
- added led-class patch handling fwnode passing differently (patch 1/3)
- adapted leds-pwm patch to new led-class (patch 2/3)
- contacted original author of leds-pwm dt binding on license issue
  (patch 3/3)

v3:
- series rebased on v5.9-rc4
- changed license of .yaml file to recommended one (patch 2/2)
- added Acked-by to both patches

v2:
- series rebased on v5.9-rc3
- added the dt-bindings update patch (2/2)

v1:
- based on v5.9-rc2
- backport on v5.4.59 tested and working

Cc: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-omap@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-amlogic@lists.infradead.org
Cc: linux-mips@vger.kernel.org

Alexander Dahl (12):
  leds: pwm: Remove platform_data support
  dt-bindings: leds: Convert pwm to yaml
  dt-bindings: mfd: Fix schema warnings for pwm-leds
  ARM: dts: at91: smartkiz: Reference led node directly
  ARM: dts: at91: Fix schema warnings for pwm-leds
  ARM: dts: berlin: Fix schema warnings for pwm-leds
  ARM: dts: exynos: Fix schema warnings for pwm-leds
  ARM: dts: imx: Fix schema warnings for pwm-leds
  ARM: dts: omap: Fix schema warnings for pwm-leds
  ARM: dts: stm32: Fix schema warnings for pwm-leds
  arm64: dts: meson: Fix schema warnings for pwm-leds
  MIPS: DTS: img: Fix schema warnings for pwm-leds

 .../devicetree/bindings/leds/leds-pwm.txt     | 50 -------------
 .../devicetree/bindings/leds/leds-pwm.yaml    | 70 +++++++++++++++++++
 .../devicetree/bindings/mfd/iqs62x.yaml       |  5 +-
 arch/arm/boot/dts/at91-kizbox.dts             | 10 +--
 arch/arm/boot/dts/at91-kizbox2-common.dtsi    |  8 +--
 arch/arm/boot/dts/at91-kizbox3-hs.dts         | 16 ++---
 arch/arm/boot/dts/at91-kizbox3_common.dtsi    | 10 +--
 arch/arm/boot/dts/at91-kizboxmini-common.dtsi |  8 +--
 arch/arm/boot/dts/at91-smartkiz.dts           |  6 +-
 arch/arm/boot/dts/at91sam9m10g45ek.dts        | 10 +--
 arch/arm/boot/dts/at91sam9rlek.dts            | 10 +--
 .../boot/dts/berlin2cd-google-chromecast.dts  |  6 +-
 arch/arm/boot/dts/exynos5422-odroidhc1.dts    |  4 +-
 arch/arm/boot/dts/exynos5422-odroidxu4.dts    |  4 +-
 .../boot/dts/exynos54xx-odroidxu-leds.dtsi    | 11 +--
 arch/arm/boot/dts/imx53-ppd.dts               | 15 ++--
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi        |  4 +-
 .../boot/dts/imx6sx-softing-vining-2000.dts   |  8 +--
 arch/arm/boot/dts/omap3-beagle-xm.dts         | 10 +--
 arch/arm/boot/dts/omap3-overo-base.dtsi       |  4 +-
 arch/arm/boot/dts/omap4-kc1.dts               |  6 +-
 arch/arm/boot/dts/omap4-sdp.dts               | 26 +++----
 arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts     | 12 ++--
 .../amlogic/meson-gxl-s905x-khadas-vim.dts    |  4 +-
 .../dts/amlogic/meson-gxm-khadas-vim2.dts     |  4 +-
 .../boot/dts/amlogic/meson-sm1-sei610.dts     |  8 +--
 arch/mips/boot/dts/img/pistachio_marduk.dts   |  5 +-
 drivers/leds/leds-pwm.c                       | 30 ++------
 28 files changed, 184 insertions(+), 180 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml


base-commit: 4f69e17c87e90f9508f498fa4771a9b77db1174b

Comments

Alexandre Belloni Oct. 28, 2020, 6:56 p.m. UTC | #1 
On Mon, 5 Oct 2020 22:34:39 +0200, Alexander Dahl wrote:
> Hei hei,
> 
> for leds-gpio you can use the properties 'function' and 'color' in the
> devicetree node and omit 'label', the label is constructed
> automatically.  This is a common feature supposed to be working for all
> LED drivers.  However it did not work until recently for the 'leds-pwm'
> driver.
> 
> [...]

Applied, thanks!

[1/2] ARM: dts: at91: smartkiz: Reference led node directly
      commit: 02e46262af5db410da5a27783833d68e2bdfb352
[2/2] ARM: dts: at91: Fix schema warnings for pwm-leds
      commit: 997ebd64df39f3916c37ca67a6eff58e79a13c73

Best regards,
Alexandre Belloni Oct. 28, 2020, 7:21 p.m. UTC | #2 
On 28/10/2020 19:56:14+0100, Alexandre Belloni wrote:
> On Mon, 5 Oct 2020 22:34:39 +0200, Alexander Dahl wrote:
> > Hei hei,
> > 
> > for leds-gpio you can use the properties 'function' and 'color' in the
> > devicetree node and omit 'label', the label is constructed
> > automatically.  This is a common feature supposed to be working for all
> > LED drivers.  However it did not work until recently for the 'leds-pwm'
> > driver.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] ARM: dts: at91: smartkiz: Reference led node directly
>       commit: 02e46262af5db410da5a27783833d68e2bdfb352
> [2/2] ARM: dts: at91: Fix schema warnings for pwm-leds
>       commit: 997ebd64df39f3916c37ca67a6eff58e79a13c73

This was obviously 04/12 and 05/12.