| Message ID | 20201029093337.21170-1-t-kristo@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3d696f42c7f4bfcc54bde545898d4b89a74f9cc0 |
| Headers | show |
| Series | [RESEND] soc: ti: ti_sci_pm_domains: check for proper args count in xlate | expand |
Hi Arnd, olof, On 10/29/20 2:33 AM, Tero Kristo wrote: > K2G devices still only use single parameter for power-domains property, > so check for this properly in the driver. Without this, every peripheral > fails to probe resulting in boot failure. > > Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") > Reported-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Acked-by: Nishanth Menon <nm@ti.com> > Acked-by: Santosh Shilimkar <ssantosh@kernel.org> > --- Can you please add this to your fixes queue ? This fixes boot failures on K2Gdevices ? > drivers/soc/ti/ti_sci_pm_domains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c > index af2126d2b2ff..8afb3f45d263 100644 > --- a/drivers/soc/ti/ti_sci_pm_domains.c > +++ b/drivers/soc/ti/ti_sci_pm_domains.c > @@ -91,7 +91,7 @@ static struct generic_pm_domain *ti_sci_pd_xlate( > struct genpd_onecell_data *genpd_data = data; > unsigned int idx = genpdspec->args[0]; > > - if (genpdspec->args_count < 2) > + if (genpdspec->args_count != 1 && genpdspec->args_count != 2) > return ERR_PTR(-EINVAL); > > if (idx >= genpd_data->num_domains) { >
Hello: This patch was applied to soc/soc.git (refs/heads/arm/fixes): On Thu, 29 Oct 2020 11:33:37 +0200 you wrote: > K2G devices still only use single parameter for power-domains property, > so check for this properly in the driver. Without this, every peripheral > fails to probe resulting in boot failure. > > Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") > Reported-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Acked-by: Nishanth Menon <nm@ti.com> > Acked-by: Santosh Shilimkar <ssantosh@kernel.org> > > [...] Here is the summary with links: - [RESEND] soc: ti: ti_sci_pm_domains: check for proper args count in xlate https://git.kernel.org/soc/soc/c/3d696f42c7f4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c index af2126d2b2ff..8afb3f45d263 100644 --- a/drivers/soc/ti/ti_sci_pm_domains.c +++ b/drivers/soc/ti/ti_sci_pm_domains.c @@ -91,7 +91,7 @@ static struct generic_pm_domain *ti_sci_pd_xlate( struct genpd_onecell_data *genpd_data = data; unsigned int idx = genpdspec->args[0]; - if (genpdspec->args_count < 2) + if (genpdspec->args_count != 1 && genpdspec->args_count != 2) return ERR_PTR(-EINVAL); if (idx >= genpd_data->num_domains) {
K2G devices still only use single parameter for power-domains property, so check for this properly in the driver. Without this, every peripheral fails to probe resulting in boot failure. Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") Reported-by: Nishanth Menon <nm@ti.com> Signed-off-by: Tero Kristo <t-kristo@ti.com> Acked-by: Nishanth Menon <nm@ti.com> Acked-by: Santosh Shilimkar <ssantosh@kernel.org> --- drivers/soc/ti/ti_sci_pm_domains.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)